From 0e971cddeea9f792fab155a65eb9e294e392802e Mon Sep 17 00:00:00 2001 From: skye Date: Wed, 15 Apr 2026 15:07:05 -0400 Subject: [PATCH] libexpr: Delete EvalState::mkSingleDerivedPathString dead function with Value& out param Part of #1136, I believe this cleans up the final instance of `Value&` used as an out parameter. Change-Id: I40153b1f11d5ca9af06cd427f22896d06a6a6964 --- lix/libexpr/eval.cc | 13 ------------- lix/libexpr/eval.hh | 9 --------- 2 files changed, 22 deletions(-) diff --git a/lix/libexpr/eval.cc b/lix/libexpr/eval.cc index 4882199f4..7675f10c4 100644 --- a/lix/libexpr/eval.cc +++ b/lix/libexpr/eval.cc @@ -908,19 +908,6 @@ std::string EvalState::mkSingleDerivedPathStringRaw( } -void EvalState::mkSingleDerivedPathString( - const SingleDerivedPath & p, - Value & v) -{ - v = { - NewValueAs::string, - mkSingleDerivedPathStringRaw(p), - NixStringContext{ - std::visit([](auto && v) -> NixStringContextElem { return v; }, p), - } - }; -} - struct CachedEvalFile { Value result; diff --git a/lix/libexpr/eval.hh b/lix/libexpr/eval.hh index 0d86f8d69..934e272be 100644 --- a/lix/libexpr/eval.hh +++ b/lix/libexpr/eval.hh @@ -817,15 +817,6 @@ public: */ Value mkOutputString(const SingleDerivedPath::Built & b, const StorePath & staticOutputPath); - /** - * Create a string representing a `SingleDerivedPath`. - * - * A combination of `mkStorePathString` and `mkOutputString`. - */ - void mkSingleDerivedPathString( - const SingleDerivedPath & p, - Value & v); - Value updateAttrs(const Value & v1, const Value & v2); Value concatLists(std::span lists, const PosIdx pos, std::string_view errorCtx);