From 36c81668a9dbd7f91def1969f2c653091085884c Mon Sep 17 00:00:00 2001
From: eldritch horrors <pennae@lix.systems>
Date: Sat, 25 Jan 2025 18:31:23 +0100
Subject: [PATCH] libstore: remove withFramedSink exception print

it's entirely not necessary. any time we'd print this exception we're
already being called as part of stack unwinding, and printing the way
it's done here causes crashes when the error is a user pressing ^C to
abort the current operation. printing all errors (including ones that
aren't interruptions) only causes unnecessary noise in terminal logs.

fixes fj#646

Change-Id: I965ff57bc9ecf7dff35963d7056aa3a5d8a83e39
---
 lix/libstore/remote-store.cc | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/lix/libstore/remote-store.cc b/lix/libstore/remote-store.cc
index 3c93bd26c..f4a6913ee 100644
--- a/lix/libstore/remote-store.cc
+++ b/lix/libstore/remote-store.cc
@@ -998,13 +998,6 @@ void RemoteStore::ConnectionHandle::withFramedSink(std::function<void(Sink & sin
     {
         if (stderrThread.joinable()) {
             stderrThread.join();
-            if (ex) {
-                try {
-                    std::rethrow_exception(ex);
-                } catch (...) {
-                    ignoreExceptionExceptInterrupt();
-                }
-            }
         }
     });