diff --git a/src/Makefile.PL b/src/Makefile.PL index 36b3e9921..9b04da7fe 100644 --- a/src/Makefile.PL +++ b/src/Makefile.PL @@ -1,5 +1,7 @@ # IMPORTANT: if you delete this file your app will not work as # expected. you have been warned +use strict; +use warnings; use inc::Module::Install; name 'Hydra'; diff --git a/src/lib/Hydra/Config.pm b/src/lib/Hydra/Config.pm index a681f1c0b..bb9918225 100644 --- a/src/lib/Hydra/Config.pm +++ b/src/lib/Hydra/Config.pm @@ -1,5 +1,8 @@ package Hydra::Config; +use strict; +use warnings; + our %configGeneralOpts = (-UseApacheInclude => 1, -IncludeAgain => 1, -IncludeRelative => 1); 1; diff --git a/src/lib/Hydra/Event.pm b/src/lib/Hydra/Event.pm index cd8bdde2d..e39543085 100644 --- a/src/lib/Hydra/Event.pm +++ b/src/lib/Hydra/Event.pm @@ -1,6 +1,7 @@ package Hydra::Event; use strict; +use warnings; use Hydra::Event::BuildFinished; use Hydra::Event::BuildStarted; use Hydra::Event::StepFinished; diff --git a/src/lib/Hydra/Helper/AddBuilds.pm b/src/lib/Hydra/Helper/AddBuilds.pm index d928943ae..6923c72a1 100644 --- a/src/lib/Hydra/Helper/AddBuilds.pm +++ b/src/lib/Hydra/Helper/AddBuilds.pm @@ -1,6 +1,7 @@ package Hydra::Helper::AddBuilds; use strict; +use warnings; use utf8; use Encode; use JSON; diff --git a/src/lib/Hydra/Helper/CatalystUtils.pm b/src/lib/Hydra/Helper/CatalystUtils.pm index cd3a0fd79..0b48e4557 100644 --- a/src/lib/Hydra/Helper/CatalystUtils.pm +++ b/src/lib/Hydra/Helper/CatalystUtils.pm @@ -2,6 +2,7 @@ package Hydra::Helper::CatalystUtils; use utf8; use strict; +use warnings; use Exporter; use Readonly; use Nix::Store; diff --git a/src/lib/Hydra/Helper/Email.pm b/src/lib/Hydra/Helper/Email.pm index 44366f43a..6bd9e5178 100644 --- a/src/lib/Hydra/Helper/Email.pm +++ b/src/lib/Hydra/Helper/Email.pm @@ -1,6 +1,7 @@ package Hydra::Helper::Email; use strict; +use warnings; use Email::MIME; use Email::Sender::Simple qw(sendmail); use Exporter 'import'; diff --git a/src/lib/Hydra/Helper/Escape.pm b/src/lib/Hydra/Helper/Escape.pm index 3037951f8..8458f8854 100644 --- a/src/lib/Hydra/Helper/Escape.pm +++ b/src/lib/Hydra/Helper/Escape.pm @@ -1,6 +1,7 @@ package Hydra::Helper::Escape; use strict; +use warnings; use base qw(Exporter); use Hydra::Helper::AttributeSet; diff --git a/src/lib/Hydra/Helper/Nix.pm b/src/lib/Hydra/Helper/Nix.pm index bd294b736..953a71141 100644 --- a/src/lib/Hydra/Helper/Nix.pm +++ b/src/lib/Hydra/Helper/Nix.pm @@ -1,6 +1,7 @@ package Hydra::Helper::Nix; use strict; +use warnings; use Exporter; use File::Path; use File::Basename; diff --git a/src/lib/Hydra/Model/DB.pm b/src/lib/Hydra/Model/DB.pm index 7514302e1..d3a401c32 100644 --- a/src/lib/Hydra/Model/DB.pm +++ b/src/lib/Hydra/Model/DB.pm @@ -1,6 +1,7 @@ package Hydra::Model::DB; use strict; +use warnings; use base 'Catalyst::Model::DBIC::Schema'; sub getHydraPath { diff --git a/src/lib/Hydra/Plugin.pm b/src/lib/Hydra/Plugin.pm index 119d27382..a3526427f 100644 --- a/src/lib/Hydra/Plugin.pm +++ b/src/lib/Hydra/Plugin.pm @@ -1,6 +1,7 @@ package Hydra::Plugin; use strict; +use warnings; use Module::Pluggable search_path => "Hydra::Plugin", instantiate => 'new'; diff --git a/src/lib/Hydra/Plugin/BazaarInput.pm b/src/lib/Hydra/Plugin/BazaarInput.pm index db26172f8..458f5141a 100644 --- a/src/lib/Hydra/Plugin/BazaarInput.pm +++ b/src/lib/Hydra/Plugin/BazaarInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::BazaarInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use Digest::SHA qw(sha256_hex); use File::Path; diff --git a/src/lib/Hydra/Plugin/BitBucketPulls.pm b/src/lib/Hydra/Plugin/BitBucketPulls.pm index 1a50f6ec1..5371d5f04 100644 --- a/src/lib/Hydra/Plugin/BitBucketPulls.pm +++ b/src/lib/Hydra/Plugin/BitBucketPulls.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::BitBucketPulls; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/BitBucketStatus.pm b/src/lib/Hydra/Plugin/BitBucketStatus.pm index 097bed00e..72ed3b6bc 100644 --- a/src/lib/Hydra/Plugin/BitBucketStatus.pm +++ b/src/lib/Hydra/Plugin/BitBucketStatus.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::BitBucketStatus; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use JSON; diff --git a/src/lib/Hydra/Plugin/CircleCINotification.pm b/src/lib/Hydra/Plugin/CircleCINotification.pm index 398fe066d..a2eb26a47 100644 --- a/src/lib/Hydra/Plugin/CircleCINotification.pm +++ b/src/lib/Hydra/Plugin/CircleCINotification.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::CircleCINotification; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/CompressLog.pm b/src/lib/Hydra/Plugin/CompressLog.pm index bf8d4327c..10e8f6cc3 100644 --- a/src/lib/Hydra/Plugin/CompressLog.pm +++ b/src/lib/Hydra/Plugin/CompressLog.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::CompressLog; use strict; +use warnings; use utf8; use parent 'Hydra::Plugin'; use Hydra::Helper::CatalystUtils; diff --git a/src/lib/Hydra/Plugin/CoverityScan.pm b/src/lib/Hydra/Plugin/CoverityScan.pm index f395100fe..53f7c3f67 100644 --- a/src/lib/Hydra/Plugin/CoverityScan.pm +++ b/src/lib/Hydra/Plugin/CoverityScan.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::CoverityScan; use strict; +use warnings; use parent 'Hydra::Plugin'; use File::Basename; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/DarcsInput.pm b/src/lib/Hydra/Plugin/DarcsInput.pm index 0091819a5..42f6a9a41 100644 --- a/src/lib/Hydra/Plugin/DarcsInput.pm +++ b/src/lib/Hydra/Plugin/DarcsInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::DarcsInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use Digest::SHA qw(sha256_hex); use File::Path; diff --git a/src/lib/Hydra/Plugin/DeclarativeJobsets.pm b/src/lib/Hydra/Plugin/DeclarativeJobsets.pm index 2b6771b55..f59fa8586 100644 --- a/src/lib/Hydra/Plugin/DeclarativeJobsets.pm +++ b/src/lib/Hydra/Plugin/DeclarativeJobsets.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::DeclarativeJobsets; use strict; +use warnings; use parent 'Hydra::Plugin'; use Hydra::Helper::AddBuilds; diff --git a/src/lib/Hydra/Plugin/EmailNotification.pm b/src/lib/Hydra/Plugin/EmailNotification.pm index 4e6c7809a..721365e15 100644 --- a/src/lib/Hydra/Plugin/EmailNotification.pm +++ b/src/lib/Hydra/Plugin/EmailNotification.pm @@ -2,6 +2,7 @@ package Hydra::Plugin::EmailNotification; use utf8; use strict; +use warnings; use parent 'Hydra::Plugin'; use POSIX qw(strftime); use Template; diff --git a/src/lib/Hydra/Plugin/GitInput.pm b/src/lib/Hydra/Plugin/GitInput.pm index 848c0deed..cd8d23e26 100644 --- a/src/lib/Hydra/Plugin/GitInput.pm +++ b/src/lib/Hydra/Plugin/GitInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GitInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use Digest::SHA qw(sha256_hex); use File::Path; diff --git a/src/lib/Hydra/Plugin/GiteaStatus.pm b/src/lib/Hydra/Plugin/GiteaStatus.pm index 75796053e..567dfd097 100644 --- a/src/lib/Hydra/Plugin/GiteaStatus.pm +++ b/src/lib/Hydra/Plugin/GiteaStatus.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GiteaStatus; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; diff --git a/src/lib/Hydra/Plugin/GithubPulls.pm b/src/lib/Hydra/Plugin/GithubPulls.pm index 6a3cc9511..fb497c768 100644 --- a/src/lib/Hydra/Plugin/GithubPulls.pm +++ b/src/lib/Hydra/Plugin/GithubPulls.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GithubPulls; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/GithubRefs.pm b/src/lib/Hydra/Plugin/GithubRefs.pm index 408159dd3..1de2672d8 100644 --- a/src/lib/Hydra/Plugin/GithubRefs.pm +++ b/src/lib/Hydra/Plugin/GithubRefs.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GithubRefs; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/GithubStatus.pm b/src/lib/Hydra/Plugin/GithubStatus.pm index e3dfc533a..cda7426ab 100644 --- a/src/lib/Hydra/Plugin/GithubStatus.pm +++ b/src/lib/Hydra/Plugin/GithubStatus.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GithubStatus; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use JSON; diff --git a/src/lib/Hydra/Plugin/GitlabPulls.pm b/src/lib/Hydra/Plugin/GitlabPulls.pm index b44a1a985..3249ecf86 100644 --- a/src/lib/Hydra/Plugin/GitlabPulls.pm +++ b/src/lib/Hydra/Plugin/GitlabPulls.pm @@ -15,6 +15,7 @@ package Hydra::Plugin::GitlabPulls; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/GitlabStatus.pm b/src/lib/Hydra/Plugin/GitlabStatus.pm index 483d99bdc..d19877edd 100644 --- a/src/lib/Hydra/Plugin/GitlabStatus.pm +++ b/src/lib/Hydra/Plugin/GitlabStatus.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::GitlabStatus; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use JSON; diff --git a/src/lib/Hydra/Plugin/HipChatNotification.pm b/src/lib/Hydra/Plugin/HipChatNotification.pm index 9a7385c40..415cfafb5 100644 --- a/src/lib/Hydra/Plugin/HipChatNotification.pm +++ b/src/lib/Hydra/Plugin/HipChatNotification.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::HipChatNotification; use strict; +use warnings; use parent 'Hydra::Plugin'; use LWP::UserAgent; use Hydra::Helper::CatalystUtils; diff --git a/src/lib/Hydra/Plugin/InfluxDBNotification.pm b/src/lib/Hydra/Plugin/InfluxDBNotification.pm index 21a3fa319..62200cc90 100644 --- a/src/lib/Hydra/Plugin/InfluxDBNotification.pm +++ b/src/lib/Hydra/Plugin/InfluxDBNotification.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::InfluxDBNotification; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/MercurialInput.pm b/src/lib/Hydra/Plugin/MercurialInput.pm index 8a9b4b431..3aaa0ba3d 100644 --- a/src/lib/Hydra/Plugin/MercurialInput.pm +++ b/src/lib/Hydra/Plugin/MercurialInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::MercurialInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use Digest::SHA qw(sha256_hex); use File::Path; diff --git a/src/lib/Hydra/Plugin/PathInput.pm b/src/lib/Hydra/Plugin/PathInput.pm index d5c490f07..e7d98da2c 100644 --- a/src/lib/Hydra/Plugin/PathInput.pm +++ b/src/lib/Hydra/Plugin/PathInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::PathInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use POSIX qw(strftime); use Hydra::Helper::Nix; diff --git a/src/lib/Hydra/Plugin/RunCommand.pm b/src/lib/Hydra/Plugin/RunCommand.pm index 7cfb63c51..33295e507 100644 --- a/src/lib/Hydra/Plugin/RunCommand.pm +++ b/src/lib/Hydra/Plugin/RunCommand.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::RunCommand; use strict; +use warnings; use parent 'Hydra::Plugin'; use experimental 'smartmatch'; use JSON; diff --git a/src/lib/Hydra/Plugin/S3Backup.pm b/src/lib/Hydra/Plugin/S3Backup.pm index 346cf239b..bdd23b2f8 100644 --- a/src/lib/Hydra/Plugin/S3Backup.pm +++ b/src/lib/Hydra/Plugin/S3Backup.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::S3Backup; use strict; +use warnings; use parent 'Hydra::Plugin'; use File::Temp; use File::Basename; diff --git a/src/lib/Hydra/Plugin/SlackNotification.pm b/src/lib/Hydra/Plugin/SlackNotification.pm index 387f92c40..5320dd7b5 100644 --- a/src/lib/Hydra/Plugin/SlackNotification.pm +++ b/src/lib/Hydra/Plugin/SlackNotification.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::SlackNotification; use strict; +use warnings; use parent 'Hydra::Plugin'; use HTTP::Request; use LWP::UserAgent; diff --git a/src/lib/Hydra/Plugin/SoTest.pm b/src/lib/Hydra/Plugin/SoTest.pm index aed7a1b8c..e3abf4ccd 100644 --- a/src/lib/Hydra/Plugin/SoTest.pm +++ b/src/lib/Hydra/Plugin/SoTest.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::SoTest; use strict; +use warnings; use parent 'Hydra::Plugin'; use Hydra::Helper::CatalystUtils; use HTTP::Request; diff --git a/src/lib/Hydra/Plugin/SubversionInput.pm b/src/lib/Hydra/Plugin/SubversionInput.pm index a8183e2ca..7879364ed 100644 --- a/src/lib/Hydra/Plugin/SubversionInput.pm +++ b/src/lib/Hydra/Plugin/SubversionInput.pm @@ -1,6 +1,7 @@ package Hydra::Plugin::SubversionInput; use strict; +use warnings; use parent 'Hydra::Plugin'; use Digest::SHA qw(sha256_hex); use Hydra::Helper::Nix; diff --git a/src/lib/Hydra/View/JSON.pm b/src/lib/Hydra/View/JSON.pm index f2ab1fc82..d8924ac3e 100644 --- a/src/lib/Hydra/View/JSON.pm +++ b/src/lib/Hydra/View/JSON.pm @@ -1,3 +1,5 @@ package Hydra::View::JSON; +use strict; +use warnings; use base qw(Catalyst::View::JSON); 1; diff --git a/src/lib/Hydra/View/NARInfo.pm b/src/lib/Hydra/View/NARInfo.pm index 460bd706c..44db78b14 100644 --- a/src/lib/Hydra/View/NARInfo.pm +++ b/src/lib/Hydra/View/NARInfo.pm @@ -1,5 +1,7 @@ package Hydra::View::NARInfo; +use strict; +use warnings; use File::Basename; use Hydra::Helper::CatalystUtils; use MIME::Base64; @@ -7,7 +9,6 @@ use Nix::Manifest; use Nix::Store; use Nix::Utils; use base qw/Catalyst::View/; -use strict; sub process { my ($self, $c) = @_; diff --git a/src/lib/Hydra/View/NixClosure.pm b/src/lib/Hydra/View/NixClosure.pm index d906dce35..c157af6b3 100644 --- a/src/lib/Hydra/View/NixClosure.pm +++ b/src/lib/Hydra/View/NixClosure.pm @@ -1,6 +1,7 @@ package Hydra::View::NixClosure; use strict; +use warnings; use base qw/Catalyst::View/; use IO::Pipe; diff --git a/src/lib/Hydra/View/NixExprs.pm b/src/lib/Hydra/View/NixExprs.pm index 194c51ece..eb68c8bca 100644 --- a/src/lib/Hydra/View/NixExprs.pm +++ b/src/lib/Hydra/View/NixExprs.pm @@ -1,6 +1,7 @@ package Hydra::View::NixExprs; use strict; +use warnings; use base qw/Catalyst::View/; use Hydra::Helper::Nix; use Hydra::Helper::Escape; diff --git a/src/lib/Hydra/View/NixLog.pm b/src/lib/Hydra/View/NixLog.pm index fb9e0e1f7..c2146bd4b 100644 --- a/src/lib/Hydra/View/NixLog.pm +++ b/src/lib/Hydra/View/NixLog.pm @@ -1,6 +1,7 @@ package Hydra::View::NixLog; use strict; +use warnings; use base qw/Catalyst::View/; use Hydra::Helper::CatalystUtils; diff --git a/src/lib/Hydra/View/NixManifest.pm b/src/lib/Hydra/View/NixManifest.pm index c64f8dab3..5b02ac060 100644 --- a/src/lib/Hydra/View/NixManifest.pm +++ b/src/lib/Hydra/View/NixManifest.pm @@ -1,6 +1,7 @@ package Hydra::View::NixManifest; use strict; +use warnings; use base qw/Catalyst::View/; use Hydra::Helper::Nix; use Nix::Store; diff --git a/src/lib/Hydra/View/NixNAR.pm b/src/lib/Hydra/View/NixNAR.pm index e1798275e..cae43275d 100644 --- a/src/lib/Hydra/View/NixNAR.pm +++ b/src/lib/Hydra/View/NixNAR.pm @@ -1,6 +1,7 @@ package Hydra::View::NixNAR; use strict; +use warnings; use base qw/Catalyst::View/; use Hydra::Helper::CatalystUtils; diff --git a/src/lib/Hydra/View/TT.pm b/src/lib/Hydra/View/TT.pm index f8b3fb647..c61762310 100644 --- a/src/lib/Hydra/View/TT.pm +++ b/src/lib/Hydra/View/TT.pm @@ -1,6 +1,7 @@ package Hydra::View::TT; use strict; +use warnings; use base 'Catalyst::View::TT'; use Hydra::Helper::Nix; use Time::Seconds; diff --git a/src/script/hydra-backfill-ids b/src/script/hydra-backfill-ids index d9fc362ab..bb7508293 100755 --- a/src/script/hydra-backfill-ids +++ b/src/script/hydra-backfill-ids @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use utf8; use Hydra::Model::DB; diff --git a/src/script/hydra-create-user b/src/script/hydra-create-user index 0ed51bd85..d0178dc15 100755 --- a/src/script/hydra-create-user +++ b/src/script/hydra-create-user @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use Hydra::Schema; use Hydra::Helper::Nix; use Hydra::Model::DB; diff --git a/src/script/hydra-dev-server b/src/script/hydra-dev-server index 4f03ee390..ea502d89d 100755 --- a/src/script/hydra-dev-server +++ b/src/script/hydra-dev-server @@ -1,5 +1,8 @@ #! /usr/bin/env perl +use strict; +use warnings; + BEGIN { $ENV{CATALYST_SCRIPT_GEN} = 40; } diff --git a/src/script/hydra-eval-jobset b/src/script/hydra-eval-jobset index 77938c853..4d44a4b0a 100755 --- a/src/script/hydra-eval-jobset +++ b/src/script/hydra-eval-jobset @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use utf8; use Config::General; use Data::Dump qw(dump); diff --git a/src/script/hydra-init b/src/script/hydra-init index ac9d4afe2..6bc38470c 100755 --- a/src/script/hydra-init +++ b/src/script/hydra-init @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use Hydra::Schema; use Hydra::Helper::Nix; use Hydra::Model::DB; diff --git a/src/script/hydra-notify b/src/script/hydra-notify index 770f0620a..b877c7ee3 100755 --- a/src/script/hydra-notify +++ b/src/script/hydra-notify @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use utf8; use Getopt::Long; use HTTP::Server::PSGI; diff --git a/src/script/hydra-s3-backup-collect-garbage b/src/script/hydra-s3-backup-collect-garbage index ae6423f74..b83945181 100755 --- a/src/script/hydra-s3-backup-collect-garbage +++ b/src/script/hydra-s3-backup-collect-garbage @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use File::Basename; use Fcntl; use IO::File; diff --git a/src/script/hydra-send-stats b/src/script/hydra-send-stats index d07d94062..8b015ae77 100755 --- a/src/script/hydra-send-stats +++ b/src/script/hydra-send-stats @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use utf8; use Hydra::Helper::Nix; use Net::Statsd; diff --git a/src/script/hydra-server b/src/script/hydra-server index b8922e933..7f0deb2e4 100755 --- a/src/script/hydra-server +++ b/src/script/hydra-server @@ -1,5 +1,8 @@ #! /usr/bin/env perl +use strict; +use warnings; + BEGIN { $ENV{CATALYST_SCRIPT_GEN} = 40; } diff --git a/src/script/hydra-update-gc-roots b/src/script/hydra-update-gc-roots index de544e534..69578e293 100755 --- a/src/script/hydra-update-gc-roots +++ b/src/script/hydra-update-gc-roots @@ -1,6 +1,7 @@ #! /usr/bin/env perl use strict; +use warnings; use File::Path; use File::stat; use File::Basename; diff --git a/src/sql/update-dbix.pl b/src/sql/update-dbix.pl index a9a18f0e1..338e65b19 100644 --- a/src/sql/update-dbix.pl +++ b/src/sql/update-dbix.pl @@ -1,4 +1,6 @@ use Cwd; +use strict; +use warnings; die "$0: dbi connection string required \n" if scalar @ARGV != 1; diff --git a/t/Config/hydra-notify.t b/t/Config/hydra-notify.t index 7fc8aa636..fb050324b 100644 --- a/t/Config/hydra-notify.t +++ b/t/Config/hydra-notify.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(hydra_config => q| diff --git a/t/Config/include.t b/t/Config/include.t index 3e57b3d4e..e161902ea 100644 --- a/t/Config/include.t +++ b/t/Config/include.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init( diff --git a/t/Config/statsd.t b/t/Config/statsd.t index be0421274..c50e8d998 100644 --- a/t/Config/statsd.t +++ b/t/Config/statsd.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(hydra_config => q| diff --git a/t/Controller/Build/evals.t b/t/Controller/Build/evals.t index b12e00c61..6cbdeac90 100644 --- a/t/Controller/Build/evals.t +++ b/t/Controller/Build/evals.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use Data::Dumper; my %ctx = test_init(); diff --git a/t/Controller/Jobset/channel.t b/t/Controller/Jobset/channel.t index cb0a59528..322abc926 100644 --- a/t/Controller/Jobset/channel.t +++ b/t/Controller/Jobset/channel.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; use IO::Uncompress::Bunzip2 qw(bunzip2); use Archive::Tar; diff --git a/t/Controller/Jobset/evals.t b/t/Controller/Jobset/evals.t index ba53124a6..221efb655 100644 --- a/t/Controller/Jobset/evals.t +++ b/t/Controller/Jobset/evals.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use Data::Dumper; my %ctx = test_init(); diff --git a/t/Controller/Jobset/http.t b/t/Controller/Jobset/http.t index be2950f0b..6b5788c5b 100644 --- a/t/Controller/Jobset/http.t +++ b/t/Controller/Jobset/http.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; use JSON qw(decode_json encode_json); diff --git a/t/Controller/Jobset/type-constraints.t b/t/Controller/Jobset/type-constraints.t index 361c7c56d..88a8e2eea 100644 --- a/t/Controller/Jobset/type-constraints.t +++ b/t/Controller/Jobset/type-constraints.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/Controller/Root/evals.t b/t/Controller/Root/evals.t index 895ef4246..2119725b4 100644 --- a/t/Controller/Root/evals.t +++ b/t/Controller/Root/evals.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use Data::Dumper; my %ctx = test_init(); diff --git a/t/Controller/metrics.t b/t/Controller/metrics.t index 8915104df..325efad9d 100644 --- a/t/Controller/metrics.t +++ b/t/Controller/metrics.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; use JSON qw(decode_json encode_json); diff --git a/t/Controller/projects.t b/t/Controller/projects.t index fb7df6ad5..068f566b5 100644 --- a/t/Controller/projects.t +++ b/t/Controller/projects.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; use JSON qw(decode_json encode_json); diff --git a/t/Event.t b/t/Event.t index a15b95ea4..908c24403 100644 --- a/t/Event.t +++ b/t/Event.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Hydra::Event; use Test2::V0; diff --git a/t/Event/BuildFinished.t b/t/Event/BuildFinished.t index 8650f95c7..298b41624 100644 --- a/t/Event/BuildFinished.t +++ b/t/Event/BuildFinished.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/Event/BuildStarted.t b/t/Event/BuildStarted.t index 04a7df549..08433d8d2 100644 --- a/t/Event/BuildStarted.t +++ b/t/Event/BuildStarted.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/Event/StepFinished.t b/t/Event/StepFinished.t index a4bc3fb93..ae2d80814 100644 --- a/t/Event/StepFinished.t +++ b/t/Event/StepFinished.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/Helper/escape.t b/t/Helper/escape.t index 22dd4d47a..424c91982 100644 --- a/t/Helper/escape.t +++ b/t/Helper/escape.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use Data::Dumper; use Test2::V0; diff --git a/t/PostgresListener.t b/t/PostgresListener.t index ac9ec502d..0249d498f 100644 --- a/t/PostgresListener.t +++ b/t/PostgresListener.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/Schema/Users.t b/t/Schema/Users.t index fd1a66e1e..b9d524195 100644 --- a/t/Schema/Users.t +++ b/t/Schema/Users.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/api-test.t b/t/api-test.t index ac1e4964a..3fee02642 100644 --- a/t/api-test.t +++ b/t/api-test.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use JSON; use File::Copy; diff --git a/t/build-products.t b/t/build-products.t index 6987b9df9..3bc62d2e8 100644 --- a/t/build-products.t +++ b/t/build-products.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/evaluate-basic.t b/t/evaluate-basic.t index c12709b20..f4c6fde81 100644 --- a/t/evaluate-basic.t +++ b/t/evaluate-basic.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/evaluate-dependent-jobsets.t b/t/evaluate-dependent-jobsets.t index c5a4085dd..19c62891a 100644 --- a/t/evaluate-dependent-jobsets.t +++ b/t/evaluate-dependent-jobsets.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/input-types/bzr-checkout.t b/t/input-types/bzr-checkout.t index ee1f90a01..297c9bd63 100644 --- a/t/input-types/bzr-checkout.t +++ b/t/input-types/bzr-checkout.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/bzr.t b/t/input-types/bzr.t index 0cc0a23d9..364481035 100644 --- a/t/input-types/bzr.t +++ b/t/input-types/bzr.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/darcs.t b/t/input-types/darcs.t index aa95a8e65..7f8bd0444 100644 --- a/t/input-types/darcs.t +++ b/t/input-types/darcs.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/deepgit.t b/t/input-types/deepgit.t index 4d418148e..487d0a831 100644 --- a/t/input-types/deepgit.t +++ b/t/input-types/deepgit.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/git-rev.t b/t/input-types/git-rev.t index 866370d2e..a1749f3b7 100644 --- a/t/input-types/git-rev.t +++ b/t/input-types/git-rev.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/git.t b/t/input-types/git.t index 0804cc1ae..ed2ab43bb 100644 --- a/t/input-types/git.t +++ b/t/input-types/git.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/hg.t b/t/input-types/hg.t index 28552288e..83d9df872 100644 --- a/t/input-types/hg.t +++ b/t/input-types/hg.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/svn-checkout.t b/t/input-types/svn-checkout.t index 48f07f099..af4e65ced 100644 --- a/t/input-types/svn-checkout.t +++ b/t/input-types/svn-checkout.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/input-types/svn.t b/t/input-types/svn.t index c2eb8cec1..44f8d44e8 100644 --- a/t/input-types/svn.t +++ b/t/input-types/svn.t @@ -1,4 +1,5 @@ use strict; +use warnings; use Setup; use TestScmInput; diff --git a/t/lib/Setup.pm b/t/lib/Setup.pm index 800c90eb7..751a81c20 100644 --- a/t/lib/Setup.pm +++ b/t/lib/Setup.pm @@ -1,6 +1,7 @@ package Setup; use strict; +use warnings; use Exporter; use Test::PostgreSQL; use File::Temp; diff --git a/t/queue-runner/default-machine-file.t b/t/queue-runner/default-machine-file.t index d57f1816f..e63482269 100644 --- a/t/queue-runner/default-machine-file.t +++ b/t/queue-runner/default-machine-file.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; my %ctx = test_init( diff --git a/t/s3-backup-test.pl b/t/s3-backup-test.pl index 372a9697e..3baa8b997 100644 --- a/t/s3-backup-test.pl +++ b/t/s3-backup-test.pl @@ -1,4 +1,5 @@ use strict; +use warnings; use File::Basename; use Hydra::Model::DB; use Hydra::Helper::Nix; diff --git a/t/scripts/hydra-create-user.t b/t/scripts/hydra-create-user.t index 3706d9111..abd0b1b8a 100644 --- a/t/scripts/hydra-create-user.t +++ b/t/scripts/hydra-create-user.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/scripts/hydra-init.t b/t/scripts/hydra-init.t index 517a14d7b..3fbcb6299 100644 --- a/t/scripts/hydra-init.t +++ b/t/scripts/hydra-init.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/scripts/hydra-send-stats.t b/t/scripts/hydra-send-stats.t index dde88cfe9..1c0e1eebf 100644 --- a/t/scripts/hydra-send-stats.t +++ b/t/scripts/hydra-send-stats.t @@ -1,5 +1,6 @@ use feature 'unicode_strings'; use strict; +use warnings; use Setup; my %ctx = test_init(); diff --git a/t/setup-notifications-jobset.pl b/t/setup-notifications-jobset.pl index 8eef78e68..709988456 100644 --- a/t/setup-notifications-jobset.pl +++ b/t/setup-notifications-jobset.pl @@ -1,3 +1,5 @@ +use strict; +use warnings; use LWP::UserAgent; use JSON;