From da9f0c494ee242f83002dfa89cc0fcd2798c3b37 Mon Sep 17 00:00:00 2001 From: rootile Date: Tue, 9 Jun 2026 19:07:56 +0200 Subject: [PATCH] tests(f2/repl): migrate failing pure eval test Change-Id: Ic8db38346c2420b2d3c5ab51fe71ef0b88f826b3 --- .../data/repl_overlays_regression_l777.test | 9 ------- .../repl_characterization.cc | 1 - .../overlays/regression_l777_pure_eval.md | 25 +++++++++++++++++++ .../overlays}/repl-overlay-trivial.nix | 0 .../repl_overlays_regression_l777.nix | 0 5 files changed, 25 insertions(+), 10 deletions(-) delete mode 100644 tests/functional/repl_characterization/data/repl_overlays_regression_l777.test create mode 100644 tests/functional2/repl_characterization/overlays/regression_l777_pure_eval.md rename tests/{functional/repl_characterization/data/extra_data => functional2/repl_characterization/overlays}/repl-overlay-trivial.nix (100%) rename tests/{functional/repl_characterization/data => functional2/repl_characterization/overlays}/repl_overlays_regression_l777.nix (100%) diff --git a/tests/functional/repl_characterization/data/repl_overlays_regression_l777.test b/tests/functional/repl_characterization/data/repl_overlays_regression_l777.test deleted file mode 100644 index 402ab96ff..000000000 --- a/tests/functional/repl_characterization/data/repl_overlays_regression_l777.test +++ /dev/null @@ -1,9 +0,0 @@ -Checks that repl-overlays work correctly in pure eval mode -@args --pure-eval -@args --repl-overlays -@args ${PWD}/extra_data/repl-overlay-trivial.nix - - nix-repl> foo - 2 - - nix-repl> :quit diff --git a/tests/functional/repl_characterization/repl_characterization.cc b/tests/functional/repl_characterization/repl_characterization.cc index 84fd6b39d..c2a61e580 100644 --- a/tests/functional/repl_characterization/repl_characterization.cc +++ b/tests/functional/repl_characterization/repl_characterization.cc @@ -176,7 +176,6 @@ TEST_F(ReplSessionTest, tidy) runReplTestPath(#name); \ } -REPL_TEST(repl_overlays_regression_l777); REPL_TEST(stack_vars); REPL_TEST(stacktrace_invalid_arg); REPL_TEST(stacktrace_oob); diff --git a/tests/functional2/repl_characterization/overlays/regression_l777_pure_eval.md b/tests/functional2/repl_characterization/overlays/regression_l777_pure_eval.md new file mode 100644 index 000000000..e0acb37bf --- /dev/null +++ b/tests/functional2/repl_characterization/overlays/regression_l777_pure_eval.md @@ -0,0 +1,25 @@ +--- +args: ['--pure-eval', '--repl-overlays', '{PWD}/repl-overlay-trivial.nix'] +should_fail: True +--- + +```output +Lix VERSION +Type :? for help. +Loading 'repl-overlays'... +error: access to absolute path '/pwd/repl-overlay-trivial.nix' is forbidden in pure eval mode (use '--impure' to override) +``` +> FIXME(rootile, 2026-06-09): This actually fails and the issue has been reopened. +> Big yaaaaaaay for the old stupid test suit which just didn't fail +> +> Remove the `should_fail` once this works again + +Check that repl-overlays work correctly in pure eval mode + +```nix +foo +:quit +``` +```output + +``` diff --git a/tests/functional/repl_characterization/data/extra_data/repl-overlay-trivial.nix b/tests/functional2/repl_characterization/overlays/repl-overlay-trivial.nix similarity index 100% rename from tests/functional/repl_characterization/data/extra_data/repl-overlay-trivial.nix rename to tests/functional2/repl_characterization/overlays/repl-overlay-trivial.nix diff --git a/tests/functional/repl_characterization/data/repl_overlays_regression_l777.nix b/tests/functional2/repl_characterization/overlays/repl_overlays_regression_l777.nix similarity index 100% rename from tests/functional/repl_characterization/data/repl_overlays_regression_l777.nix rename to tests/functional2/repl_characterization/overlays/repl_overlays_regression_l777.nix