From df58bffc0fd20293afd7a7d94b56a1bb580fc75e Mon Sep 17 00:00:00 2001 From: Raito Bezarius Date: Sat, 5 Jul 2025 17:56:27 +0200 Subject: [PATCH] doc/rl-next: missed credit for the symbol reuse work We missed xokdvium being author on cl/3300. This is something we absolutely want to avoid. We credit xokdvium in the RL and add a note on this problem. Thanks to xokdvium for reaching out in private to us so we can repair this mistake. Change-Id: I094d0f95b6647104621d6b228e69a4529a300304 Signed-off-by: Raito Bezarius --- doc/manual/change-authors.yml | 3 +++ doc/manual/rl-next/symbol-value-reuse.md | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/manual/change-authors.yml b/doc/manual/change-authors.yml index 6da33d0a0..2d9b2c618 100644 --- a/doc/manual/change-authors.yml +++ b/doc/manual/change-authors.yml @@ -252,6 +252,9 @@ winter: xanderio: github: xanderio +xokdvium: + github: xokdvium + yorickvp: github: yorickvp diff --git a/doc/manual/rl-next/symbol-value-reuse.md b/doc/manual/rl-next/symbol-value-reuse.md index 7d3221968..1454eba81 100644 --- a/doc/manual/rl-next/symbol-value-reuse.md +++ b/doc/manual/rl-next/symbol-value-reuse.md @@ -3,7 +3,7 @@ synopsis: Symbols reuses once-allocated Value to reduce garbage collected alloca issues: [] cls: [3308, 3300, 3314, 3310, 3312, 3313] category: Improvements -credits: [raito, horrors, thubrecht, nan-git] +credits: [raito, horrors, thubrecht, xokdvium, nan-git] --- In the Lix evaluator, **symbols** represent immutable strings, like those used @@ -30,3 +30,5 @@ As a result, this reduces the number of allocations, leading to: * A slight decrease in CPU usage during Nix evaluations. This change is inspired by https://github.com/NixOS/nix/pull/13258 but the approach is different. + +**Note** : [`xokdvium`](https://github.com/xokdvium) is the rightful author of https://gerrit.lix.systems/c/lix/+/3300 and the credit was missed on our end during the development process. We are deeply sorry for this mistake.