Merge pull request #8148 from hercules-ci/fix-issue-8119-printValue-tBlackhole-abort

eval: Fix crash on missing printValue tBlackhole case
2023-04-03 16:05:55 +02:00
parent ac4318a1b9 1c55544a42
commit f3a6de6ba9
2 changed files with 17 additions and 0 deletions
@@ -173,7 +173,17 @@ void Value::print(const SymbolTable & symbols, std::ostream & str,
    case tFloat:
        str << fpoint;
        break;
+    case tBlackhole:
+        // Although we know for sure that it's going to be an infinite recursion
+        // when this value is accessed _in the current context_, it's likely
+        // that the user will misinterpret a simpler «infinite recursion» output
+        // as a definitive statement about the value, while in fact it may be
+        // a valid value after `builtins.trace` and perhaps some other steps
+        // have completed.
+        str << "«potential infinite recursion»";
+        break;
    default:
+        printError("Nix evaluator internal error: Value::print(): invalid value type %1%", internalType);
        abort();
    }
 }