guiwf/lix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
19,011 Commits 37 Branches 40 Tags
052d04512e6172a2b8a87aef94c909882c083e28
Commit Graph
19011 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Robert HensingandGitHub 7b39a388b3 Merge pull request #8566 from inclyc/nixd/value-print-depth 
libexpr: extend `Value::print` to allow limited depth
 2023-07-01 20:08:52 +02:00
Robert HensingandGitHub d05d175ddf Merge pull request #8619 from hercules-ci/issue-8616-dont-install-test-program 
tests: Don't install test-libstoreconsumer program
 2023-07-01 00:17:07 +02:00
Robert Hensing a6c17097d2 tests: Don't install test-libstoreconsumer program 
Sorry about that.
Fixes https://github.com/NixOS/nix/issues/8616
 2023-06-30 23:36:27 +02:00
Robert Hensing fefb947132 tests/signing.sh: Check signature checking error message 
We should check error messages, so that we know the command fails for
the right reason.
Alternatively, a mere typo can run the test undetected.
 2023-06-30 18:23:44 +02:00
Robert Hensing 1db81f7107 tests/fetchClosure: Improve coverage of new and some existing flows 2023-06-30 18:23:44 +02:00
Robert HensingRobert HensingValentin Gagarin
 		40052c7613 fetchClosure: Docs and error message improvements 
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
 2023-06-30 18:23:42 +02:00
Robert Hensing 50de11d662 doc: Improve fetchClosure documentation 2023-06-30 18:23:24 +02:00
Robert Hensing 32c69e2b17 doc: Typo 2023-06-30 18:22:47 +02:00
Robert Hensing dc79636007 fetchClosure: Refactor: replace enableRewriting 
A single variable is nice and self-contained.
 2023-06-30 18:22:47 +02:00
Robert Hensing 5bdca46117 fetchClosure: Split into three cases 2023-06-30 18:22:47 +02:00
Robert Hensing 55888633dd makeContentAddressed: Add single path helper 2023-06-30 18:22:47 +02:00
Robert Hensing 8dca95386c fetchClosure: Disallow toPath for inputAddressed = true 2023-06-30 18:22:47 +02:00
Robert Hensing 508aa58e67 fetchClosure: Always check that inputAddressed matches the result 2023-06-30 18:22:47 +02:00
Robert Hensing ea30f152b7 fetchClosure: Allow input addressed paths in pure mode 
When explicitly requested by the caller, as suggested in the meeting
(https://github.com/NixOS/nix/pull/8090#issuecomment-1531139324)

> @edolstra: { toPath } vs { fromPath } is too implicit

I've opted for the `inputAddressed = true` requirement, because it
we did not agree on renaming the path attributes.

> @roberth: more explicit
> @edolstra: except for the direction; not immediately clear in which direction the rewriting happens

This is in fact the most explicit syntax and a bit redundant, which is
good, because that redundancy lets us deliver an error message that
reminds expression authors that CA provides a better experience to
their users.
 2023-06-30 18:22:43 +02:00
Robert Hensing 7e5b6d2c45 fetchClosure: Refactor: rename toCA -> enableRewriting 2023-06-30 18:19:56 +02:00
Robert Hensing 0f6d596df5 fetchClosure: Factor out attribute hint 2023-06-30 18:19:56 +02:00
Eelco DolstraandGitHub 7b5ca7ebe2 Merge pull request #8614 from ShamrockLee/quickfix-exdev 
linkOrCopy: Fallback upon cross-device link error (EXDEV)
 2023-06-30 16:42:42 +02:00
Yueh-Shun Li eebfe989a5 linkOrCopy: Fallback upon cross-device link error (EXDEV) 
Fix building derivations in local chroot store on OpenAFS,
where hard linking accross directories causes cross-device link error
(EXDEV).
 2023-06-30 21:12:26 +08:00
Robert HensingandGitHub 685f1bb386 labeler.yml: tests -> with-tests 2023-06-30 15:10:07 +02:00
Eelco DolstraandGitHub a0c617348b Merge pull request #8589 from jfroche/sign-paths-as-allowed-user 
Allow to sign path as unprivileged user
 2023-06-30 13:13:42 +02:00
Robert HensingandGitHub 1632f08ea2 Merge pull request #8600 from inclyc/libexpr/fix-leaking-in-stripIndentation 
libexpr: fix leaking `es2` in stripIndentation (parser.y)
 2023-06-29 11:31:53 +02:00
github-actions[bot]andmergify[bot] db318eee75 flake.lock: Update 
Flake lock file updates:

• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/71fb97f0d875fd4de4994dfb849f2c75e17eb6c3' (2023-06-01)
  → 'github:hercules-ci/flake-parts/37dd7bb15791c86d55c5121740a1887ab55ee836' (2023-06-26)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/4137dbc2737384c4cc9e2b5d3c4cfc6ba6e5f0cc' (2023-06-26)
  → 'github:NixOS/nixpkgs/2c8591ad6a6f9d679817a94f847c59b0d1e3289e' (2023-06-29)
 2023-06-29 01:32:32 +00:00
Yingchi Long 3468cbaf47 libexpr: fix leaking es2 in stripIndentation (parser.y) 2023-06-28 22:38:44 +08:00
Valentin GagarinandGitHub b8bb8026d2 Merge pull request #8571 from NixOS/split-out-testing-page 2023-06-28 01:22:29 +02:00
John Ericson ca49e13414 Split testing into its own page in the contribution guide 
`hacking.md` has gotten really big!
 2023-06-27 18:27:49 -04:00
John Ericson 2ccc02515f Trailing commas in redirects 
This avoids diff noise when more are added. Unlike with JSON, this is
allowed in JS.
 2023-06-27 18:23:06 -04:00
Jean-François Roche 80c9259756 Allow to sign path as unprivileged user 
User can now sign path as unprivileged/allowed user

refs #1708
 2023-06-27 18:31:31 +02:00
John EricsonandGitHub 71d4fd8ebb Merge pull request #8330 from NixOS/doc-auto-builtin-constants 
Automatically document builtin constants
 2023-06-27 11:52:59 -04:00
John EricsonEelco DolstraRobert HensingValentin Gagarin
 		22b278e011 Automatically document builtin constants 
This is done in roughly the same way builtin functions are documented.

Also auto-link experimental features for primops, subsuming PR #8371.

Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
 2023-06-27 09:37:54 -04:00
John EricsonandRobert Hensing d40f0e534d Don't say this when we still pollute the global scope 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
 2023-06-27 09:37:31 -04:00
John EricsonandRobert Hensing 4da7c86618 Switch example to a primop this is less ill-advised 
Any primop will do for this, so might as well use one that isn't impure.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
 2023-06-27 09:34:36 -04:00
John Ericson e8067daf09 Generialize showType 2023-06-27 09:11:42 -04:00
Maximilian BoschandGitHub 559fd7ffe7 nix flake check: improve error message if overlay is not a lambda (#8582) 
* nix flake check: improve error message if overlay is not a lambda

Suppose you have an overlay like this

    {
      inputs = { /* ... */ };
      outputs = { flake-utils, ... }: flake-utils.lib.eachDefaultSystem
        (system: {
          overlays.default = final: prev: {

          };
        });
    }

then `nix flake check` (correctly) fails because `overlays` are supposed
to have the structure `overlays.<name> = final: prev: exp`. However, the
error-message is a little bit counter-intuitive:

    error: overlay does not take an argument named 'final'

While one might guess where the error actually comes from because the
trace above says `… while checking the overlay 'overlays.x86_64-linux'`
this is still pretty confusing because it complains about an argument
not being named `final` even though that's evidently the case.

With this change, the error-message actually makes it clear what's
wrong:

    [ma27@carsten:~/Projects/nix/tmp]$ nix flake check --extra-experimental-features 'nix-command flakes' path:$(pwd)
    error:
           … while checking flake output 'overlays'

             at /nix/store/clgblnxx003hyrq8qkz5ab6kgqkck6qc-source/flake.nix:4:5:

                3|   outputs = { ... }: {
                4|     overlays.x86_64-linux.snens = final: prev: {
                 |     ^
                5|       kek = throw "snens";

           … while checking the overlay 'overlays.x86_64-linux'

             at /nix/store/clgblnxx003hyrq8qkz5ab6kgqkck6qc-source/flake.nix:4:5:

                3|   outputs = { ... }: {
                4|     overlays.x86_64-linux.snens = final: prev: {
                 |     ^
                5|       kek = throw "snens";

           error: overlay is not a lambda, but a set instead
 2023-06-27 14:58:29 +02:00
Eelco DolstraandGitHub 8e770dac9f Merge pull request #8576 from obsidiansystems/findPath-cleanup 
Use a struct not `std::pair` for `SearchPathElem`
 2023-06-26 12:37:06 +02:00
github-actions[bot]andmergify[bot] a74d3c5724 flake.lock: Update 
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/3fb3ce0b6b84d3b4e7b49e142da9c5764b563058' (2023-06-22)
  → 'github:NixOS/nixpkgs/4137dbc2737384c4cc9e2b5d3c4cfc6ba6e5f0cc' (2023-06-26)
 2023-06-26 01:47:15 +00:00
adisbladisandGitHub 85802b58a0 Merge pull request #221 from nix-community/readme-memory-limit-exceed 
Add note about momentarily exceeding memory limits
 2023-06-26 12:19:19 +12:00
adisbladis 3df60c2621 Add note about momentarily exceeding memory limits 2023-06-26 12:10:51 +12:00
Théophane HufschmittandGitHub 60f06a1714 Merge pull request #5385 from Enzime/add/dirty-rev 
Add `dirtyRev` and `dirtyShortRev` to `fetchGit`
 2023-06-24 14:55:31 +02:00
Michael Hoang a7b49086c7 Add dirtyRev and dirtyShortRev to fetchGit 
Fixes #4682
 2023-06-24 14:17:25 +10:00
John Ericson 484290a9e0 Use a struct not std::pair for SearchPathElem 
I got very confused trying to keep all the `first` and `second` straight
reading the code, *especially* as there is also another `(boolean,
string)` pair type also being used.

Named fields is much better.

There are other cleanups that we can do (for example, the existing
TODO), but we can do them later. Doing them now would just make this
harder to review.
 2023-06-23 12:01:10 -04:00
Robert HensingandGitHub fd4f03b8fd Merge pull request #8519 from fricklerhandwerk/reword-trusted-users 
reword documentation on trusted users and substituters
 2023-06-23 13:08:46 +02:00
Eelco DolstraandGitHub 8350f06d6c Merge pull request #8574 from inclyc/nixd/remove-unused-token 
libexpr: remove unused token `ATTRPATH` in token declaration
 2023-06-23 12:02:40 +02:00
Yingchi Long 9d8c4ac446 libexpr: remove unused token ATTRPATH in token declaration 2023-06-23 13:35:41 +08:00
John EricsonandGitHub 2026ad11d0 Merge pull request #8572 from obsidiansystems/document-exit-codes 
Better document build failure exit codes
 2023-06-22 19:04:49 -04:00
John Ericson 97df060588 Better document build failure exit codes 
- Improved API docs from comment

- Exit codes are for `nix-build`, not just `nix-store --release`

- Make note in tests so the magic numbers are not surprising

Picking up where #8387 left off.
 2023-06-22 14:29:45 -04:00
John EricsonandGitHub 2291232dc1 Merge pull request #8387 from layus/fix-tests 
Check exact error codes in linux-sandbox.sh
 2023-06-22 13:56:03 -04:00
John EricsonandGitHub 78e1e3c753 Merge pull request #8565 from obsidiansystems/profile-delete-docs 
Clarify docs on deleting generations, including fixing a mistake
 2023-06-22 10:27:40 -04:00
Valentin GagarinandGitHub 0ab962d83f Merge pull request #8556 from fricklerhandwerk/hacking-headings 
hacking guide: use more self-descriptive section headings
 2023-06-22 13:45:31 +02:00
Yingchi Long 1400fde144 libexpr: extend Value::print to allow limited depth 2023-06-22 18:28:30 +08:00
Yingchi Long c48277c1c1 libexpr: add tests for nix::Value::print 2023-06-22 18:28:30 +08:00