eldritch horrors
b4c6bfd72a
this gives us a semblance of a stack trace if async tasks fail, like:
Async task trace (probably incomplete):
#0: virtual kj::Promise<Result<Goal::WorkResult>> nix::LocalDerivationGoal::tryLocalBuild() (lix/libstore/build/local-derivation-goal.cc:257:33)
building of '//0ppb5aj4p3vp0icnkq4yibajw1czvdja-bash52-009.drv^out' from .drv file
#1: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::outputsSubstitutionTried() (lix/libstore/build/derivation-goal.cc:381:47)
building of '//0ppb5aj4p3vp0icnkq4yibajw1czvdja-bash52-009.drv^out' from .drv file
#2: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::loadDerivation() (lix/libstore/build/derivation-goal.cc:213:41)
building of '//0ppb5aj4p3vp0icnkq4yibajw1czvdja-bash52-009.drv^out' from .drv file
#3: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::gaveUpOnSubstitution() (lix/libstore/build/derivation-goal.cc:453:62)
building of '//f8rkb1vam9y9vi9scsm1v213b01rm72h-bash-5.2p37.drv^out' from .drv file
#4: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::outputsSubstitutionTried() (lix/libstore/build/derivation-goal.cc:381:47)
building of '//f8rkb1vam9y9vi9scsm1v213b01rm72h-bash-5.2p37.drv^out' from .drv file
#5: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::loadDerivation() (lix/libstore/build/derivation-goal.cc:213:41)
building of '//f8rkb1vam9y9vi9scsm1v213b01rm72h-bash-5.2p37.drv^out' from .drv file
#6: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::gaveUpOnSubstitution() (lix/libstore/build/derivation-goal.cc:453:62)
building of '//qa9jvc4j6fphzwr63k5c829b2hr04q6z-foo.drv^*' from .drv file
#7: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::outputsSubstitutionTried() (lix/libstore/build/derivation-goal.cc:381:47)
building of '//qa9jvc4j6fphzwr63k5c829b2hr04q6z-foo.drv^*' from .drv file
#8: kj::Promise<Result<Goal::WorkResult>> nix::DerivationGoal::loadDerivation() (lix/libstore/build/derivation-goal.cc:213:41)
building of '//qa9jvc4j6fphzwr63k5c829b2hr04q6z-foo.drv^*' from .drv file
#9: virtual kj::Promise<Result<void>> nix::Store::buildPaths(const std::vector<DerivedPath> &, BuildMode, std::shared_ptr<Store>) (lix/libstore/build/entry-points.cc:20:11)
it's not much, but it's a lot better than nothing. sadly we're forced
to disable another clang-tidy warning now, but since that one's about
assert side effects being compiled out in release mode and we've long
since decided to just not do that we are not affected by this at all.
also see #724 for a related but different approach to origin tracing.
Change-Id: I8161f82ca39d0b271316ea4df80513acc1b06a03
41 lines
1.4 KiB
YAML
41 lines
1.4 KiB
YAML
UseColor: true
|
|
Checks:
|
|
- -*
|
|
- bugprone-*
|
|
# too many warnings
|
|
- -bugprone-assignment-in-if-condition
|
|
# too many warnings
|
|
- -bugprone-narrowing-conversions
|
|
# kind of nonsense
|
|
- -bugprone-easily-swappable-parameters
|
|
# too many warnings for now
|
|
- -bugprone-implicit-widening-of-multiplication-result
|
|
# Lix's exception handling is Questionable
|
|
- -bugprone-empty-catch
|
|
# many warnings
|
|
- -bugprone-unchecked-optional-access
|
|
# many warnings, seems like a questionable lint
|
|
- -bugprone-branch-clone
|
|
# extremely noisy before clang 19: https://github.com/llvm/llvm-project/issues/93959
|
|
- -bugprone-multi-level-implicit-pointer-conversion
|
|
# we don't compile out our asserts
|
|
- -bugprone-assert-side-effect
|
|
# all thrown exceptions must derive from std::exception
|
|
- hicpp-exception-baseclass
|
|
# capturing async lambdas are dangerous
|
|
- cppcoreguidelines-avoid-capturing-lambda-coroutines
|
|
# crimes must be appropriately declared as crimes
|
|
- cppcoreguidelines-pro-type-cstyle-cast
|
|
- lix-*
|
|
# This can not yet be applied to Lix itself since we need to do source
|
|
# reorganization so that lix/ include paths work.
|
|
- -lix-fixincludes
|
|
# This lint is included as an example, but the lib function it replaces is
|
|
# already gone.
|
|
- -lix-hasprefixsuffix
|
|
|
|
|
|
CheckOptions:
|
|
bugprone-reserved-identifier.AllowedIdentifiers: '__asan_default_options'
|
|
bugprone-unused-return-value.AllowCastToVoid: true
|