Linus Heckemann
d19593d00b
The expected and the obtained path are now printed as part of the error message, making comparing them easier when they're both at hand. The extra rethrow for the hash-mismatch exception in the bmCheck case has been removed, allowing the path to be registered as in the non-check case. This makes having both paths at hand a lot more likely! The determinism check logic was incorrect for content-addressed paths, since it only ever tried to compare the path produced, even if this was not the path expected (in the case of fixed-output derivations) or the path previously produced (in the case of non-fixed CA derivations). This made little sense, because that would always be the same path if it exists! The determinism check is therefore now bypassed for CA paths. Having a correct determinism check for non-fixed CA derivations and running the diff hook for fixed-output derivations would be nice, but feels out of scope and bypassing the inapplicable logic isn't a regression from the previous behaviour. Change-Id: I5fc14fb477c8c7d2f5bdedad5591af916f72b128
165 lines
6.4 KiB
Bash
165 lines
6.4 KiB
Bash
source common.sh
|
||
|
||
# XXX: This shouldn’t be, but #4813 cause this test to fail
|
||
buggyNeedLocalStore "see #4813"
|
||
|
||
checkBuildTempDirRemoved ()
|
||
{
|
||
buildDir=$(sed -n 's/CHECK_TMPDIR=//p' $1 | head -1)
|
||
checkBuildIdFile=${buildDir}/checkBuildId
|
||
[[ ! -f $checkBuildIdFile ]] || ! grep $checkBuildId $checkBuildIdFile
|
||
}
|
||
|
||
# written to build temp directories to verify created by this instance
|
||
checkBuildId=$(date +%s%N)
|
||
|
||
clearStore
|
||
|
||
nix-build dependencies.nix --no-out-link
|
||
nix-build dependencies.nix --no-out-link --check
|
||
|
||
# Build failure exit codes (100, 104, etc.) are from
|
||
# doc/manual/src/command-ref/status-build-failure.md
|
||
|
||
# check for dangling temporary build directories
|
||
# only retain if build fails and --keep-failed is specified, or...
|
||
# ...build is non-deterministic and --check and --keep-failed are both specified
|
||
nix-build check.nix -A failed --argstr checkBuildId $checkBuildId \
|
||
--no-out-link 2> $TEST_ROOT/log || status=$?
|
||
[ "$status" = "100" ]
|
||
checkBuildTempDirRemoved $TEST_ROOT/log
|
||
|
||
nix-build check.nix -A failed --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --keep-failed 2> $TEST_ROOT/log || status=$?
|
||
[ "$status" = "100" ]
|
||
if checkBuildTempDirRemoved $TEST_ROOT/log; then false; fi
|
||
|
||
test_custom_build_dir() {
|
||
local customBuildDir="$TEST_ROOT/custom-build-dir"
|
||
|
||
# Nix does not create the parent directories, and perhaps it shouldn't try to
|
||
# decide the permissions of build-dir.
|
||
mkdir "$customBuildDir"
|
||
nix-build check.nix -A failed --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --keep-failed --option build-dir "$TEST_ROOT/custom-build-dir" 2> $TEST_ROOT/log || status=$?
|
||
[ "$status" = "100" ]
|
||
[[ 1 == "$(count "$customBuildDir/nix-build-"*)" ]]
|
||
local buildDir="$customBuildDir/nix-build-"*
|
||
grep $checkBuildId $buildDir/checkBuildId
|
||
}
|
||
test_custom_build_dir
|
||
|
||
test_custom_temp_dir() {
|
||
# like test_custom_build_dir(), but uses the temp-dir setting instead
|
||
# build-dir inherits from temp-dir when build-dir is unset
|
||
local customTempDir="$TEST_ROOT/custom-temp-dir"
|
||
|
||
mkdir "$customTempDir"
|
||
nix-build check.nix -A failed --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --keep-failed --option temp-dir "$customTempDir" 2> $TEST_ROOT/log || status=$?
|
||
[ "$status" = "100" ]
|
||
[[ 1 == "$(count "$customTempDir/nix-build-"*)" ]]
|
||
local buildDir="$customTempDir/nix-build-"*
|
||
grep $checkBuildId $buildDir/checkBuildId
|
||
|
||
# also check a separate code path that doesn't involve build-dir
|
||
# nix-shell uses temp-dir for its rcfile path
|
||
rcpath=$(NIX_BUILD_SHELL=$SHELL nix-shell check.nix -A deterministic --option temp-dir "$customTempDir" --run 'echo $0' 2> $TEST_ROOT/log)
|
||
# rcpath is <temp-dir>/nix-shell-*/rc
|
||
[[ $rcpath = "$customTempDir"/* ]]
|
||
}
|
||
test_custom_temp_dir
|
||
|
||
test_shell_preserves_tmpdir() {
|
||
# ensure commands that spawn interactive shells don't overwrite TMPDIR with temp-dir
|
||
local envTempDir=$TEST_ROOT/shell-temp-dir-env
|
||
mkdir $envTempDir
|
||
local settingTempDir=$TEST_ROOT/shell-temp-dir-setting
|
||
mkdir $settingTempDir
|
||
|
||
# FIXME: switch to check.nix's deterministic once `nix develop` doesn't need `outputs`
|
||
# https://git.lix.systems/lix-project/lix/issues/556
|
||
local expr='with import ./config.nix; mkDerivation { name = "foo"; buildCommand = "echo foo > $out"; outputs = [ "out" ]; }'
|
||
|
||
local output
|
||
output=$(TMPDIR=$envTempDir NIX_BUILD_SHELL=$SHELL nix-shell -E "$expr" --option temp-dir "$settingTempDir" --command 'echo $TMPDIR' 2> $TEST_ROOT/log)
|
||
[[ $output = "$envTempDir" ]]
|
||
|
||
output=$(TMPDIR=$envTempDir nix develop --impure -E "$expr" --option temp-dir "$settingTempDir" --command bash -c 'echo $TMPDIR' 2> $TEST_ROOT/log)
|
||
[[ $output = "$envTempDir"/nix-shell.* ]]
|
||
|
||
output=$(TMPDIR=$envTempDir nix shell --impure -E "$expr" --option temp-dir "$settingTempDir" --command bash -c 'echo $TMPDIR' 2> $TEST_ROOT/log)
|
||
[[ $output = "$envTempDir" ]]
|
||
}
|
||
test_shell_preserves_tmpdir
|
||
|
||
nix-build check.nix -A deterministic --argstr checkBuildId $checkBuildId \
|
||
--no-out-link 2> $TEST_ROOT/log
|
||
checkBuildTempDirRemoved $TEST_ROOT/log
|
||
|
||
nix-build check.nix -A deterministic --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --check --keep-failed 2> $TEST_ROOT/log
|
||
if grepQuiet 'may not be deterministic' $TEST_ROOT/log; then false; fi
|
||
checkBuildTempDirRemoved $TEST_ROOT/log
|
||
|
||
nix-build check.nix -A nondeterministic --argstr checkBuildId $checkBuildId \
|
||
--no-out-link 2> $TEST_ROOT/log
|
||
checkBuildTempDirRemoved $TEST_ROOT/log
|
||
|
||
nix-build check.nix -A nondeterministic --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --check 2> $TEST_ROOT/log || status=$?
|
||
grep 'may not be deterministic' $TEST_ROOT/log
|
||
# the differences in both outputs should be reported
|
||
[[ $(grep -c 'differs' $TEST_ROOT/log) = 2 ]]
|
||
[ "$status" = "104" ]
|
||
checkBuildTempDirRemoved $TEST_ROOT/log
|
||
|
||
nix-build check.nix -A nondeterministic --argstr checkBuildId $checkBuildId \
|
||
--no-out-link --check --keep-failed 2> $TEST_ROOT/log || status=$?
|
||
grep 'may not be deterministic' $TEST_ROOT/log
|
||
[ "$status" = "104" ]
|
||
if checkBuildTempDirRemoved $TEST_ROOT/log; then false; fi
|
||
|
||
clearStore
|
||
|
||
path=$(nix-build check.nix -A fetchurl --no-out-link)
|
||
|
||
chmod +w $path
|
||
echo foo > $path
|
||
chmod -w $path
|
||
|
||
nix-build check.nix -A fetchurl --no-out-link --check
|
||
# Note: "check" doesn't repair anything, it just compares to the hash stored in the database.
|
||
[[ $(cat $path) = foo ]]
|
||
|
||
nix-build check.nix -A fetchurl --no-out-link --repair
|
||
[[ $(cat $path) != foo ]]
|
||
|
||
echo 'Hello World' > $TEST_ROOT/dummy
|
||
nix-build check.nix -A hashmismatch --no-out-link 2>mismatch-output || status=$?
|
||
[ "$status" = "102" ]
|
||
obtained=$(grep "got path:" mismatch-output | awk '{ print $3 }')
|
||
# The path that actually came out should exist
|
||
[ -e "$obtained" ]
|
||
# and be registered as valid
|
||
nix-store -q --references "$obtained" >/dev/null
|
||
|
||
echo -n > $TEST_ROOT/dummy
|
||
successful_fod=$(nix-build check.nix -A hashmismatch --no-out-link)
|
||
|
||
echo 'Hello World 2' > $TEST_ROOT/dummy
|
||
nix-build check.nix -A hashmismatch --no-out-link --check 2>mismatch-output || status=$?
|
||
cat mismatch-output >&2
|
||
[ "$status" = "102" ]
|
||
grep -E "expected path:\s+$successful_fod" mismatch-output
|
||
obtained=$(grep "got path:" mismatch-output | awk '{ print $3 }')
|
||
# The path that actually came out should exist
|
||
[ -e "$obtained" ]
|
||
# and be registered as valid
|
||
nix-store -q --references "$obtained" >/dev/null
|
||
|
||
# Multiple failures with --keep-going
|
||
nix-build check.nix -A nondeterministic --no-out-link
|
||
nix-build check.nix -A nondeterministic -A hashmismatch --no-out-link --check --keep-going || status=$?
|
||
[ "$status" = "110" ]
|