eldritch horrors
08252967a8
libexpr: Support structured error classes
...
While preparing PRs like #9753 , I've had to change error messages in
dozens of code paths. It would be nice if instead of
EvalError("expected 'boolean' but found '%1%'", showType(v))
we could write
TypeError(v, "boolean")
or similar. Then, changing the error message could be a mechanical
refactor with the compiler pointing out places the constructor needs to
be changed, rather than the error-prone process of grepping through the
codebase. Structured errors would also help prevent the "same" error
from having multiple slightly different messages, and could be a first
step towards error codes / an error index.
This PR reworks the exception infrastructure in `libexpr` to
support exception types with different constructor signatures than
`BaseError`. Actually refactoring the exceptions to use structured data
will come in a future PR (this one is big enough already, as it has to
touch every exception in `libexpr`).
The core design is in `eval-error.hh`. Generally, errors like this:
state.error("'%s' is not a string", getAttrPathStr())
.debugThrow<TypeError>()
are transformed like this:
state.error<TypeError>("'%s' is not a string", getAttrPathStr())
.debugThrow()
The type annotation has moved from `ErrorBuilder::debugThrow` to
`EvalState::error`.
(cherry picked from commit c6a89c1a1659b31694c0fbcd21d78a6dd521c732)
Change-Id: Iced91ba4e00ca9e801518071fb43798936cbd05a
2024-03-09 04:47:05 -07:00
..
2024-03-04 07:15:08 +01:00
2024-03-04 08:17:32 +01:00
2023-12-01 12:06:43 -05:00
2024-03-09 00:05:41 -07:00
2024-03-07 14:50:43 +01:00
2024-03-09 04:47:05 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:11:25 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 04:38:33 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:57:44 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:15:08 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:02 +01:00
2024-03-04 07:50:02 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 00:43:51 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2024-01-11 07:21:16 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:21:01 +01:00
2024-03-04 07:11:25 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 05:39:12 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 14:50:43 +01:00
2024-03-04 07:26:34 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 05:27:18 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 03:34:00 +01:00
2024-03-07 03:34:00 +01:00
2024-03-07 03:34:00 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:51:49 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-01-11 07:21:16 -05:00
2023-12-01 12:06:43 -05:00
2024-03-09 03:37:35 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:40:12 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:55 +01:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:55 +01:00
2024-03-04 05:06:32 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:17:32 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 05:34:19 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 05:59:15 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00