Files
lix/tests/functional2/commands/test_build/test_build_output_cycles.py
T
Rebecca Turnerandrootile cb34b56fea tests/functional2: Fix Python LSP by adjusting imports
See: cl/4840

When importing Python modules, we include `functional2` in the module
path, like this:

    from functional2.testlib.fixtures.env import ManagedEnv

This means that python expects to see a file like
`functional2/testlib/fixtures/env.py`. We run `pytest` from `tests/` in
the `justfile` and have `tests/functional2/__init__.py` so `pytest` in
`meson` is able to find these imports.

However, language servers generally consider the `pyproject.toml` to be
the project root, so (e.g.) `pyright` is unable to follow any of the
`functional2` imports, leading to lots of spurious errors.

In cl/4840 I moved `tests/functional2/pyproject.toml` to
`tests/pyproject.toml`, which worked but was considered aesthetically
unappealing.

This diff is much larger but it's a more elegant solution.

Change-Id: I2983c7b87f88f59a4e3521451a9f5acd6a6a6964
2026-01-23 15:06:51 +01:00

79 lines
2.2 KiB
Python

import re
import sys
from testlib.fixtures.file_helper import with_files, CopyFile
from testlib.fixtures.nix import Nix
from testlib.utils import get_global_asset_pack
_files = {
"output-cycles.nix": CopyFile("assets/test_build/output-cycles.nix"),
**get_global_asset_pack("dependencies"),
}
def _assert_cycle_tree(output: str, regexes: list[str]):
lines = output.splitlines()
start = next((k for k, v in enumerate(lines) if "Shown below are the files inside" in v), None)
assert start is not None
for line, regex in enumerate(regexes, start=start + 1):
assert re.search(regex, lines[line])
def _assert_cycle_message(err: str):
assert (
len(
re.findall(
r"cycle detected in build of '.*' in the references of output 'bar' from output 'foo'",
err,
)
)
== 1
)
@with_files(_files)
def test_cycle(nix: Nix):
res = nix.nix_build(["output-cycles.nix", "-A", "cycle"]).run().expect(1)
err = res.stderr_plain
_assert_cycle_message(err)
if sys.platform == "linux":
_assert_cycle_tree(
err,
[
r"/store/.*-cycle-bar",
r"└───lib/libfoo: ….*cycle-baz.*",
r" →.*/store/.*-cycle-baz",
r" └───share/lalala:.*-cycle-foo.*",
],
)
@with_files(_files)
def test_cycle_in_dependency(nix: Nix):
res = nix.nix_build(["output-cycles.nix", "-A", "as_dependency"]).run().expect(1)
err = res.stderr_plain
_assert_cycle_message(err)
assert "error: 1 dependencies of derivation" in err
@with_files(_files)
def test_cycle_with_deps(nix: Nix):
res = nix.nix_build(["output-cycles.nix", "-A", "cycle-with-deps"]).run().expect(1)
err = res.stderr_plain
_assert_cycle_message(err)
if sys.platform == "linux":
_assert_cycle_tree(
err,
[
r"/store/.*-cycle-with-deps-bar",
r"└───txt: ….*cycle-with-deps-foo.*",
r" →.*/store/.*-cycle-with-deps-foo",
r" └───txt:.*-cycle-with-deps-bar.*",
],
)