Maximilian Bosch and Jade Lovelace
87fd1f024c
Reapply "libfetchers: make attribute / URL query handling consistent"
...
The original attempt at this introduced a regression; this commit
reverts the revert and fixes the regression.
This reverts commit 3e151d4d77 .
Fix to the regression:
flakeref: fix handling of `?dir=` param for flakes in subdirs
As reported in #419[1], accessing a flake in a subdir of a Git
repository fails with the previous commit[2] applied with the error
error: unsupported Git input attribute 'dir'
The problem is that the `dir`-param is inserted into the parsed URL if a
flake is fetched from the subdir of a Git repository. However, for the
fetching part this isn't even needed. The fix is to just pass `subdir`
as second argument to `FlakeRef` (which needs a `basedir` that can be
empty) and leave the parsedURL as-is.
Added a regression test to make sure we don't run into this again.
[1] https://git.lix.systems/lix-project/lix/issues/419
[2] e22172aaf6b6a366cecd3c025590e68fa2b91bcc,
originally 3e151d4d77
Change-Id: I2c72d5a32e406a7ca308e271730bd0af01c5d18b
2024-08-01 15:41:30 -07:00
..
2024-06-01 20:31:24 +02:00
2024-06-24 11:30:32 +03:00
2023-12-01 12:06:43 -05:00
2024-05-07 17:04:30 -06:00
2024-08-01 15:41:30 -07:00
2024-07-13 00:59:33 +02:00
2024-06-01 20:31:24 +02:00
2024-05-07 17:04:30 -06:00
2024-07-18 18:41:28 +02:00
2024-05-07 17:04:30 -06:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-05-06 18:56:40 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-01 20:31:24 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-01 20:31:24 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-27 22:44:16 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-24 11:30:32 +03:00
2023-12-01 12:06:43 -05:00
2024-03-25 17:36:24 -06:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2024-05-03 16:26:16 +02:00
2024-06-01 20:31:24 +02:00
2024-03-04 08:57:44 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:15:08 +01:00
2023-12-01 12:06:43 -05:00
2024-07-04 17:43:03 -06:00
2024-06-30 19:28:14 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-05-08 19:31:43 +00:00
2024-05-08 19:31:43 +00:00
2024-03-07 10:46:47 +01:00
2024-03-29 22:57:40 -07:00
2024-08-01 15:41:30 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-18 00:54:51 +00:00
2024-05-04 16:48:07 +02:00
2023-12-01 12:06:43 -05:00
2024-06-01 20:31:24 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:02 +01:00
2024-03-04 07:50:02 +01:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2024-06-27 22:44:16 -07:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-07-19 20:55:55 +00:00
2024-04-25 23:24:21 -04:00
2024-04-25 23:24:21 -04:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2024-01-11 07:21:16 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-01 20:31:24 +02:00
2024-03-04 07:21:01 +01:00
2024-05-06 18:56:40 +02:00
2024-06-24 14:00:43 -07:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2024-04-08 15:40:12 -07:00
2024-03-29 22:57:40 -07:00
2024-05-31 07:54:18 +00:00
2024-04-08 15:40:12 -07:00
2024-03-04 07:26:34 +01:00
2024-08-01 15:41:30 -07:00
2024-05-30 03:07:21 +00:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2024-03-04 05:27:18 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2024-07-09 13:55:05 +00:00
2024-03-07 03:34:00 +01:00
2024-03-07 03:34:00 +01:00
2024-03-07 03:34:00 +01:00
2024-06-24 14:00:43 -07:00
2024-05-24 15:15:42 -06:00
2024-03-04 08:51:49 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-05-12 23:04:21 +02:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-06-24 14:00:43 -07:00
2024-06-24 14:00:43 -07:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-04-08 15:40:12 -07:00
2023-12-01 12:06:43 -05:00
2024-07-17 21:48:13 +00:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:40:12 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:55 +01:00
2023-12-01 12:06:43 -05:00
2024-03-04 07:50:55 +01:00
2024-03-29 22:57:40 -07:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-29 22:57:40 -07:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 08:17:32 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-07 10:46:47 +01:00
2024-06-23 11:52:49 +00:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-04-11 15:43:58 +03:00
2024-03-04 05:34:19 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-14 14:30:38 -07:00
2023-12-01 12:06:43 -05:00
2024-05-28 04:20:00 +00:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00
2024-03-04 05:59:15 +01:00
2023-12-01 12:06:43 -05:00
2023-12-01 12:06:43 -05:00