git@71rd.net
0e115a4828
When assigning an a value to NIX_GET_COMPLETIONS that could not be parsed as an integer lix would just crash, as the value was directly passed to stoi, without handling the return value. This change switches the parsing to use string2Int and throws an exception if the return value is empty. The behaviour of lix is slightly changed through, as the value of the variable was previously parsed to an int and then assigned to a variable of size_t. This change in behaviour can only be observed in cases where the value of NIX_GET_COMPLETIONS is chosen so when it overflows it would be valid index of the provided arguments again. Through this change the variable is parsed as a size_t and negative values are rejected. Change-Id: Idf7c5740274c6e07d5bb13d7e2ed32764bfc27f8
85 lines
2.9 KiB
Bash
85 lines
2.9 KiB
Bash
source common.sh
|
||
|
||
cd "$TEST_ROOT"
|
||
|
||
mkdir -p dep
|
||
cat <<EOF > dep/flake.nix
|
||
{
|
||
outputs = i: { };
|
||
}
|
||
EOF
|
||
mkdir -p foo
|
||
cat <<EOF > foo/flake.nix
|
||
{
|
||
inputs.a.url = "path:$(realpath dep)";
|
||
|
||
outputs = i: {
|
||
sampleOutput = 1;
|
||
};
|
||
}
|
||
EOF
|
||
mkdir -p bar
|
||
cat <<EOF > bar/flake.nix
|
||
{
|
||
inputs.b.url = "path:$(realpath dep)";
|
||
|
||
outputs = i: {
|
||
sampleOutput = 1;
|
||
};
|
||
}
|
||
EOF
|
||
mkdir -p err
|
||
cat <<EOF > err/flake.nix
|
||
throw "error"
|
||
EOF
|
||
|
||
# Test the completion of a subcommand
|
||
[[ "$(NIX_GET_COMPLETIONS=1 nix buil)" == $'normal\nbuild\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=2 nix flake metad)" == $'normal\nmetadata\t' ]]
|
||
|
||
|
||
# Test how completion fails if the value cant be parsed as a number
|
||
NIX_GET_COMPLETIONS="-" expectStderr 1 nix \
|
||
| grepQuiet "error: Invalid value for environment variable NIX_GET_COMPLETIONS:"
|
||
|
||
# Test how completion fails if the number is not a valid index for the number of arguments
|
||
NIX_GET_COMPLETIONS=0 expectStderr 1 nix \
|
||
| grepQuiet "error: Invalid word number to get completion for:"
|
||
NIX_GET_COMPLETIONS=4 expectStderr 1 nix build a \
|
||
| grepQuiet "error: Invalid word number to get completion for:"
|
||
|
||
# Filename completion
|
||
[[ "$(NIX_GET_COMPLETIONS=2 nix build ./f)" == $'filenames\n./foo\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=2 nix build ./nonexistent)" == $'filenames' ]]
|
||
|
||
# Input override completion
|
||
[[ "$(NIX_GET_COMPLETIONS=4 nix build ./foo --override-input '')" == $'normal\na\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=5 nix flake show ./foo --override-input '')" == $'normal\na\t' ]]
|
||
cd ./foo
|
||
[[ "$(NIX_GET_COMPLETIONS=3 nix flake update '')" == $'normal\na\t' ]]
|
||
cd ..
|
||
[[ "$(NIX_GET_COMPLETIONS=5 nix flake update --flake './foo' '')" == $'normal\na\t' ]]
|
||
## With multiple input flakes
|
||
[[ "$(NIX_GET_COMPLETIONS=5 nix build ./foo ./bar --override-input '')" == $'normal\na\t\nb\t' ]]
|
||
## With tilde expansion
|
||
[[ "$(HOME=$PWD NIX_GET_COMPLETIONS=4 nix build '~/foo' --override-input '')" == $'normal\na\t' ]]
|
||
[[ "$(HOME=$PWD NIX_GET_COMPLETIONS=5 nix flake update --flake '~/foo' '')" == $'normal\na\t' ]]
|
||
## Out of order
|
||
[[ "$(NIX_GET_COMPLETIONS=3 nix build --override-input '' '' ./foo)" == $'normal\na\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=4 nix build ./foo --override-input '' '' ./bar)" == $'normal\na\t\nb\t' ]]
|
||
|
||
# Cli flag completion
|
||
NIX_GET_COMPLETIONS=2 nix build --log-form | grep -- "--log-format"
|
||
|
||
# Config option completion
|
||
## With `--option`
|
||
NIX_GET_COMPLETIONS=3 nix build --option allow-import-from | grep -- "allow-import-from-derivation"
|
||
## As a cli flag – not working atm
|
||
# NIX_GET_COMPLETIONS=2 nix build --allow-import-from | grep -- "allow-import-from-derivation"
|
||
|
||
# Attr path completions
|
||
[[ "$(NIX_GET_COMPLETIONS=2 nix eval ./foo\#sam)" == $'attrs\n./foo#sampleOutput\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=4 nix eval --file ./foo/flake.nix outp)" == $'attrs\noutputs\t' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=4 nix eval --file ./err/flake.nix outp 2>&1)" == $'attrs' ]]
|
||
[[ "$(NIX_GET_COMPLETIONS=2 nix eval ./err\# 2>&1)" == $'attrs' ]]
|