Raito Bezarius 7bd82718e2 libstore/platform/linux: destroy cgroup before we release user locks ...

User locks are taken to avoid another build grabbing the same UID.

Under build user contention, it is possible to recycle the same UID from
another build which did not run the Goal destructor yet.

Prior to this change, cgroups were destroyed at Goal destruction time,
but user locks were released at `buildDone()` time.

Therefore, it was possible to have 2 builds fights for the same cgroup
and mess with it, resulting in confusion.

To avoid this, we override `cleanupHookFinally` in charge to release the
user locks and we destroy the cgroup before releasing the locks.

Statistics are kept in the `cgroup` object a bit longer and can be
obtained at `killSandbox(true)` time.

`AutoDestroyCgroup::kill` now ignore if the cgroup path has already been
destroyed, as kill is idempotent.

Reported-by: Ramses <@rvdp:infosec.exchange>
Reported-by: Frederico Schonborn <@fredericoschonborn:matrix.org>
Change-Id: Idfbf9aaf010c5f718f2c1c38548383d912d8ee95
Signed-off-by: Raito Bezarius <raito@lix.systems>

2025-06-11 13:47:38 +02:00

..

build

libstore/build/worker: clean up cgroup error messages typos

2025-06-10 23:29:10 +02:00

builtins

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

file-transfer-settings

libstore: set connect-timeout to 5

2025-03-15 16:17:25 +01:00

platform

libstore/platform/linux: destroy cgroup before we release user locks

2025-06-11 13:47:38 +02:00

settings

libstore/build: cgroup delegation to sandbox

2025-06-10 20:50:00 +02:00

binary-cache-store.cc

libstore/binary-cache-store: skip NAR listings if it's not possible to serialize it

2025-06-10 15:22:22 +00:00

binary-cache-store.hh

libstore: remove realisation query support

2025-05-20 17:43:46 +00:00

build-result.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

build-result.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

builtins.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

common-protocol-impl.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

common-protocol.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

common-protocol.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

content-address.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

content-address.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

crypto.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

crypto.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

daemon.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

daemon.hh

chore: drop experimental feature recursive-nix

2025-04-25 17:09:01 +02:00

derivations.cc

libstore: add derivation wire generator

2025-06-06 18:09:46 +02:00

derivations.hh

libstore: add derivation wire generator

2025-06-06 18:09:46 +02:00

derived-path.cc

libstore: rename query{,Static}PartialDerivationOutputMap

2025-05-20 17:43:46 +00:00

derived-path.hh

libstore: de-ref {Derived,Built}Path::Built drvPath

2025-05-12 13:37:54 +02:00

dummy-store.cc

libstore: remove realisation query support

2025-05-20 17:43:46 +00:00

dummy-store.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

dummy-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

export-import.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

filetransfer.cc

Merge "dtrace: fix on macOS (except in the package)" into main

2025-04-24 16:33:48 +00:00

filetransfer.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

fs-accessor.hh

libstore: asyncify FSAccessor, listNar

2025-03-05 18:49:45 +01:00

gc-store.hh

gc: allow continuing deletion even if some paths are still live

2025-03-11 14:10:32 +01:00

gc.cc

gc: delay throwing error until cleanup is complete

2025-06-02 20:05:32 +02:00

globals.cc

treewide: add nix::JSON

2025-03-23 20:42:39 +00:00

globals.hh

treewide: add nix::JSON

2025-03-23 20:42:39 +00:00

http-binary-cache-store.cc

libstore: asyncify Store::isTrustedClient

2025-03-05 16:42:11 +01:00

http-binary-cache-store.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

http-binary-cache-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

indirect-root-store.hh

libstore: asyncify IndirectRootStore::addIndirectRoot

2025-03-05 16:42:11 +01:00

legacy-ssh-store.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

legacy-ssh-store.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

legacy-ssh-store.md

libstore: allow specifying port for ssh[-ng] stores

2025-02-22 20:37:45 +01:00

length-prefixed-protocol-helper.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

lix-store.pc.in

pkg-config: remove legacy include paths!

2025-01-16 00:12:57 -08:00

local-binary-cache-store.cc

libstore: asyncify Store::queryAllValidPaths

2025-03-05 18:49:45 +01:00

local-binary-cache-store.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

local-binary-cache-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

local-fs-store.cc

libutil: explicitly mark ref(shared_ptr) as unsafe

2025-04-05 21:57:45 +02:00

local-fs-store.hh

libstore: asyncify Store::narFromPath

2025-03-05 18:49:45 +01:00

local-store.cc

libstore: remove ca database bits from LocalStore

2025-05-20 17:43:46 +00:00

local-store.hh

libstore: rename query{,Static}PartialDerivationOutputMap

2025-05-20 17:43:46 +00:00

local-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

lock.cc

libstore: split tryLockFile lockFile

2025-02-03 21:56:26 +01:00

lock.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

log-store.cc

libstore: asyncify LogStore::getBuildLogExact

2025-02-24 15:09:02 +00:00

log-store.hh

libstore: asyncify LogStore::addBuildLog

2025-02-24 15:09:02 +00:00

machines.cc

libstore: asyncify openStore

2025-02-08 12:45:15 +00:00

machines.hh

libstore: asyncify openStore

2025-02-08 12:45:15 +00:00

make-content-addressed.cc

libstore: asyncify Store::queryPathInfo{,Uncached}

2025-03-05 18:49:45 +01:00

make-content-addressed.hh

libstore: asyncify makeContentAddressed

2025-02-08 13:50:33 +00:00

meson.build

libstore/build: cgroup delegation to sandbox

2025-06-10 20:50:00 +02:00

misc.cc

libstore: rename query{,Static}PartialDerivationOutputMap

2025-05-20 17:43:46 +00:00

names.cc

treewide: wrap std::regex_error

2025-04-24 13:48:15 +00:00

names.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

nar-accessor.cc

treewide: handle JSON parse errors

2025-03-27 08:56:14 +00:00

nar-accessor.hh

treewide: add nix::JSON

2025-03-23 20:42:39 +00:00

nar-info-disk-cache.cc

libstore: remove unused realisation disk caching

2025-05-20 17:43:46 +00:00

nar-info-disk-cache.hh

libstore: remove unused realisation disk caching

2025-05-20 17:43:46 +00:00

nar-info.cc

nar-info: use string views for construction

2025-01-23 11:21:24 +00:00

nar-info.hh

nar-info: use string views for construction

2025-01-23 11:21:24 +00:00

optimise-store.cc

libstore: asyncify Store::isValidPath

2025-03-05 18:49:45 +01:00

outputs-spec.cc

treewide: wrap std::regex_error

2025-04-24 13:48:15 +00:00

outputs-spec.hh

libutil: remove json-impls.hh

2025-03-23 22:29:58 +00:00

parsed-derivations.cc

libstore: remove Derivation::hasKnownOutputPaths

2025-05-20 17:43:46 +00:00

parsed-derivations.hh

treewide: add nix::JSON

2025-03-23 20:42:39 +00:00

path-info.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

path-info.hh

libstore: add worker serializer for SubstitutablePathInfo

2025-06-06 18:09:46 +02:00

path-references.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

path-references.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

path-regex.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

path-with-outputs.cc

libstore: de-ref {Derived,Built}Path::Built drvPath

2025-05-12 13:37:54 +02:00

path-with-outputs.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

path.cc

libutil: canonPath: error instead of panic on empty path

2025-04-12 16:31:28 +02:00

path.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

pathlocks.cc

libstore: mark blocking file locks as never async

2025-02-16 14:59:32 +00:00

pathlocks.hh

libstore: mark blocking file locks as never async

2025-02-16 14:59:32 +00:00

platform.cc

treewide: store optional refs as exactly this

2025-04-05 21:57:45 +02:00

profiles.cc

libstore/profiles: do not dereference current generation if it doesn't exist

2025-05-11 01:07:18 +02:00

profiles.hh

libstore: mark blocking file locks as never async

2025-02-16 14:59:32 +00:00

realisation.cc

libstore: remove unused realisation methods

2025-05-20 17:43:46 +00:00

realisation.hh

libstore: remove unused realisation methods

2025-05-20 17:43:46 +00:00

remote-fs-accessor.cc

treewide: add nix::JSON

2025-03-23 20:42:39 +00:00

remote-fs-accessor.hh

libstore: asyncify FSAccessor, listNar

2025-03-05 18:49:45 +01:00

remote-store-connection.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

remote-store.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

remote-store.hh

libstore: remove pre-2.18 protocols

2025-06-02 22:43:24 +00:00

s3-binary-cache-store.cc

libstore: asyncify Store::queryPathInfo{,Uncached}

2025-03-05 18:49:45 +01:00

s3-binary-cache-store.hh

libstore: don't derive store classes from their configs

2024-11-20 14:59:40 +01:00

s3-binary-cache-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

s3.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

schema.sql

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

serve-protocol-impl.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

serve-protocol.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

serve-protocol.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

sqlite.cc

libstore: drastically shorten sqlite busy timeout

2025-03-05 17:34:25 +01:00

sqlite.hh

libutil: split retrySQLite into sync and async

2025-02-22 17:59:54 +00:00

ssh-store.cc

libstore: SSHMaster master -> SSH ssh

2025-04-21 13:43:44 +00:00

ssh-store.hh

libstore: allow specifying port for ssh[-ng] stores

2025-02-22 20:37:45 +01:00

ssh-store.md

libstore: allow specifying port for ssh[-ng] stores

2025-02-22 20:37:45 +01:00

ssh.cc

libstore/ssh: remove echo started check

2025-05-18 18:45:26 +02:00

ssh.hh

libstore: SSHMaster master -> SSH ssh

2025-04-21 13:43:44 +00:00

store-api.cc

libstore: rename query{,Static}PartialDerivationOutputMap

2025-05-20 17:43:46 +00:00

store-api.hh

libstore: rename query{,Static}PartialDerivationOutputMap

2025-05-20 17:43:46 +00:00

store-cast.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

temporary-dir.cc

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

temporary-dir.hh

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

trace-probes.d

dtrace: fix on macOS (except in the package)

2025-03-26 10:40:50 -07:00

uds-remote-store.cc

libutil/libstore: asyncify Pool

2025-03-05 23:07:20 +01:00

uds-remote-store.hh

libstore: asyncify Store::narFromPath

2025-03-05 18:49:45 +01:00

uds-remote-store.md

fix tooling after include reorganization

2024-11-19 22:55:32 +00:00

worker-protocol-impl.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

worker-protocol.cc

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00

worker-protocol.hh

libstore: associate wire connection states with stores

2025-06-06 18:09:46 +02:00