Files
lix/tests/functional2/testlib/fixtures/test_command.py
T
Rebecca Turnerandrootile cb34b56fea tests/functional2: Fix Python LSP by adjusting imports
See: cl/4840

When importing Python modules, we include `functional2` in the module
path, like this:

    from functional2.testlib.fixtures.env import ManagedEnv

This means that python expects to see a file like
`functional2/testlib/fixtures/env.py`. We run `pytest` from `tests/` in
the `justfile` and have `tests/functional2/__init__.py` so `pytest` in
`meson` is able to find these imports.

However, language servers generally consider the `pyproject.toml` to be
the project root, so (e.g.) `pyright` is unable to follow any of the
`functional2` imports, leading to lots of spurious errors.

In cl/4840 I moved `tests/functional2/pyproject.toml` to
`tests/pyproject.toml`, which worked but was considered aesthetically
unappealing.

This diff is much larger but it's a more elegant solution.

Change-Id: I2983c7b87f88f59a4e3521451a9f5acd6a6a6964
2026-01-23 15:06:51 +01:00

82 lines
2.3 KiB
Python

import logging
import stat
from collections.abc import Callable
from subprocess import CalledProcessError
import pytest
from _pytest.logging import LogCaptureFixture
from testlib.fixtures.command import Command
from testlib.fixtures.env import ManagedEnv
from testlib.fixtures.file_helper import File, with_files
def test_command_valid_runs(command: Callable[[list[str]], Command]):
cmd = command(["echo", "water"])
cmd.run().ok()
def test_command_captures_stdout(command: Callable[[list[str]], Command]):
cmd = command(["echo", "fire"])
res = cmd.run().ok()
assert res.stdout_s == "fire\n"
def test_command_plain_strips(command: Callable[[list[str]], Command]):
cmd = command(["echo", " earth "])
res = cmd.run().ok()
assert res.stdout_plain == "earth"
def test_command_stdin_passed_correctly(command: Callable[[list[str]], Command]):
inp = b"air"
cmd = command(["cat", "/dev/stdin"]).with_stdin(inp)
res = cmd.run().ok()
assert res.stdout == inp
def test_command_expect_failure(env: ManagedEnv):
env.path.add_program("grep")
Command(_env=env, argv=["grep", "xxx"], stdin=b"").run().expect(1)
@with_files(
{
"script.sh": File(
"#!/bin/sh\necho forb\nexit 1", mode=stat.S_IRWXU | stat.S_IRWXG | stat.S_IRWXO
)
}
)
def test_command_ok_fails_on_bad_exit_code(
command: Callable[[list[str]], Command], caplog: LogCaptureFixture
):
cmd = command(["./script.sh"])
with pytest.raises(CalledProcessError), caplog.at_level(logging.ERROR):
cmd.run().ok()
msgs = caplog.messages
assert len(msgs) == 2
out_msg, err_msg = msgs
assert out_msg == "stdout: forb\n"
assert err_msg == "stderr: "
@with_files(
{
"script.sh": File(
"#!/bin/sh\necho drgn fops\nexit 2", mode=stat.S_IRWXU | stat.S_IRWXG | stat.S_IRWXO
)
}
)
def test_command_exec_fails_on_other_bad_exit_code(
command: Callable[[list[str]], Command], caplog: LogCaptureFixture
):
cmd = command(["./script.sh"])
with pytest.raises(CalledProcessError), caplog.at_level(logging.ERROR):
cmd.run().expect(1)
msgs = caplog.messages
assert len(msgs) == 2
out_msg, err_msg = msgs
assert out_msg == "stdout: drgn fops\n"
assert err_msg == "stderr: "