guiwf/lix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
e3ac0d9c19cff71d166e67d4fe11cbd7b65a1ffe
lix/tests/functional
T
History
Maximilian Bosch de4cfec46a libstore: fix reporting output cycles on drvs with references to other drvs 
Closes #1064

The culprit here is that `genGraphString` is only invoked with the
store-paths associated with the outputs of the derivation, so when
filling `dependents`, the `graph_data.find(p)` call would return the end
of the iterator when doing this for references to other store-paths.

As a result, the code wrote information behind the graph data-structure
causing a corruption. For me, this resulted in a SIGSEGV most of the
time and in a few cases in an uncaught `map::at`-exception as reported
by Niklas.

This patch changes two aspects of the original implementation:

* When filling `dependents` in the node-set, use `map.at()` instead of
  `map.find()->second`. The latter doesn't make any sense and was the
  cause of corrupting memory. The `at` would've made it far easier to
  spot this in the first place.

* Filter out store-paths that don't belong to a different output of the
  derivation when creating `outputGraph`. This variable is used on two
  places, `genGraphString` and for topological sorting.

  The latter already filters out store-paths from a different drv, so
  this is happening now when creating the variable in the first place
  such that `genGraphString` never ends up with corrupt data in the
  first place. This is the actual bugfix.

Implemented a regression-test for this case to be sure.

Change-Id: Ie02144d89c32b0a776cb1ece0601d0229315ebc3
(cherry picked from commit 0a5f474a25)
2025-12-08 07:20:51 +01:00
..
common
tests/functional: support loading (contributed) plugins
2025-07-28 23:00:44 +00:00
config
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
flakes
libexpr/flake: add inputs.self.submodules flake attribute
2025-08-13 03:05:49 +00:00
lang
libexpr: don't inline small lists into values
2025-09-29 15:22:41 +02:00
logging
libstore: more precise origin info for strange structured logs
2025-02-16 14:15:36 +01:00
nested-sandboxing
chore: rebrand Nix to Lix when it makes sense
2024-06-01 20:31:24 +02:00
nix-shell
lix/nix-shell: cleanup of shell directories happens in Lix itself
2025-10-29 20:13:23 +01:00
plugins
Revert "contrib/plugins: init with mTLS store example"
2025-07-29 03:34:49 +00:00
repl_characterization
treewide: lint syscalls for c string safety
2025-10-10 16:13:54 +00:00
test-libstoreconsumer
libstore: use OpenSSL for Ed25519 signatures
2025-08-25 17:11:45 +00:00
bad.tar.xz
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
bash-profile.sh
chore: remove monolithic coreutils requirement
2024-10-30 15:12:35 +04:00
big-derivation-attr.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
binary-cache-build-remote.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
binary-cache-regression-fj647.sh
Revert "libstore: always load localstore public keys"
2025-01-23 17:57:52 -08:00
binary-cache.sh
libstore/binary-cache: default to zstd for compression
2025-10-30 15:10:10 +01:00
brotli.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-delete.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
build-dry.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-hook-ca-fixed.nix
libstore: flush log lines only from handleBuilderOutput
2025-10-13 11:26:49 +00:00
build-hook-ca-floating.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-hook.nix
libstore: flush log lines only from handleBuilderOutput
2025-10-13 11:26:49 +00:00
build-jobless.sh
libstore: diagnose local build failure in goal
2024-08-25 19:55:47 +02:00
build-remote-content-addressed-fixed.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-input-addressed.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless-after.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless-should-fail-0.sh
libstore: don't default build-dir to temp-dir
2025-06-24 10:49:49 +00:00
build-remote-trustless-should-pass-0.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless-should-pass-1.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless-should-pass-2.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless-should-pass-3.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
build-remote-trustless.sh
libstore: don't default build-dir to temp-dir
2025-06-24 10:49:49 +00:00
build-remote.sh
libstore: fix remote build failures killing everything
2025-07-22 15:32:25 +02:00
build.sh
tests/functional2: migrate build.sh
2025-09-21 13:58:26 +02:00
case-hack.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
case.nar
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
cert-test.nix
libstore/build: rewire builder's environment in presence of a global CA
2025-07-27 19:42:37 +00:00
check-outputs.nix
libstore: fix reporting output cycles on drvs with references to other drvs
2025-12-08 07:20:51 +01:00
check-refs.nix
local-derivation-goal: improve "illegal reference" error
2025-01-20 15:05:50 +01:00
check-refs.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
check-reqs.nix
libstore: show forbidden chain(s) to forbidden path from disallowedRequisites
2025-07-07 11:44:17 +00:00
check-reqs.sh
libstore: show forbidden chain(s) to forbidden path from disallowedRequisites
2025-07-07 11:44:17 +00:00
check.nix
libstore: report all differing outputs rather than just the first
2024-10-29 18:34:54 +01:00
check.sh
libstore: skip the nested build directory on Darwin
2025-11-14 14:58:15 +01:00
common.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
completions.sh
libutil/args: fix crash when NIX_GET_COMPLETIONS is not a number
2025-05-27 22:20:22 +00:00
compression-levels.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
compute-levels.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
config.nix.in
chore: remove monolithic coreutils requirement
2024-10-30 15:12:35 +04:00
config.sh
Rename nix show-config to nix config show
2024-05-03 16:26:16 +02:00
daemon-trust.sh
tests/functional/daemon-trust: fallback to uid
2025-11-03 18:24:07 +01:00
db-migration.sh
chore: rebrand Nix to Lix when it makes sense
2024-06-01 20:31:24 +02:00
dependencies.builder0.sh
why-depends: asyncify printNode
2025-07-07 11:44:17 +00:00
dependencies.nix
why-depends: asyncify printNode
2025-07-07 11:44:17 +00:00
dependencies.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
derivation-json.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
dummy
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
dump-db.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
eval-store.sh
Merge pull request #9589 from obsidiansystems/floating-content-addressing-derivations-eval-store
2024-03-04 07:15:08 +01:00
eval.nix
feat(nix-instantiate): add --raw flag
2025-05-29 15:25:12 +02:00
eval.sh
feat(nix-instantiate): add --raw flag
2025-05-29 15:25:12 +02:00
experimental-features.sh
libexpr/flake: allow automatic rejection of configuration options from flakes
2024-06-30 19:28:14 +02:00
export-graph.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
export-graph.sh
why-depends: asyncify printNode
2025-07-07 11:44:17 +00:00
export.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
extra-sandbox-profile.nix
libstore: Fix sandbox=relaxed
2024-05-08 19:31:43 +00:00
extra-sandbox-profile.sh
libstore: Fix sandbox=relaxed
2024-05-08 19:31:43 +00:00
failing.nix
Merge pull request #9032 from Ma27/structured-attrs-env-vars
2024-03-07 10:46:47 +01:00
fetchClosure.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
fetchers.sh
libfetchers: factorize inputFromAttrs
2025-05-22 14:00:19 +02:00
fetchGit.sh
libfetchers/git: restore compat with builtins.fetchGit from 2.3
2024-09-28 14:52:06 +02:00
fetchGitLocked.sh
fix: Consider fetchGit locked when narHash is present
2025-05-28 22:24:23 +00:00
fetchGitRefs.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
fetchGitSubmodules.sh
treewide: Stop using URL literals
2024-08-17 15:48:10 +00:00
fetchMercurial.sh
libfetchers/mercurial: handle "evil refs" gracefully
2025-01-26 11:22:03 +01:00
fetchPath.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
fetchTree-file.sh
fix!: file type flake inputs are always recursive hashed
2025-03-21 13:19:15 -07:00
fetchurl.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
filter-source.nix
libexpr: rectify filtering logic for filter builtins under chroot stores
2025-02-27 00:26:48 +01:00
filter-source.sh
libexpr: rectify filtering logic for filter builtins under chroot stores
2025-02-27 00:26:48 +01:00
fixed.builder1.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
fixed.builder2.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
fixed.nix
libstore: Show illegal path references in fixed-outputs derivations
2025-05-08 20:23:12 +02:00
fixed.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
fmt.sh
fix(nix fmt): remove the default "." argument
2024-09-26 14:32:29 -07:00
fmt.simple.sh
fix(nix fmt): remove the default "." argument
2024-09-26 14:32:29 -07:00
fod-failing.nix
store: guess the URL of failing fixed-output derivations
2024-06-27 22:44:16 -07:00
function-trace.sh
Add pre-commit checks
2024-03-29 22:57:40 -07:00
gc-auto.sh
libstore/gc: fix auto-GC blocking indefinitely during evaluation
2025-06-01 18:59:23 +02:00
gc-concurrent2.builder.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
gc-concurrent.builder.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
gc-concurrent.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
gc-concurrent.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
gc-non-blocking.sh
gc: refactor the gc server thread out into a class without changing it
2024-07-19 20:55:55 +00:00
gc-runtime.nix
gc: Find roots using libproc on Darwin
2024-04-25 23:24:21 -04:00
gc-runtime.sh
gc: Find roots using libproc on Darwin
2024-04-25 23:24:21 -04:00
gc.sh
gc: delay throwing error until cleanup is complete
2025-06-02 20:05:32 +02:00
hash-check.nix
Remove ancient let from 2 test files
2024-10-14 17:19:22 +04:00
hermetic.nix
Merge pull request #9032 from Ma27/structured-attrs-env-vars
2024-03-07 10:46:47 +01:00
ifd.nix
Merge branch '2.18-maintenance' into ifd-buildStore-2.18
2024-01-11 07:21:16 -05:00
import-derivation.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
import-derivation.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
impure-derivations.nix
cli: disallow impure derivations
2025-05-11 17:26:55 +02:00
impure-eval.sh
libcmd: munge evalSettings in the right place
2024-12-06 00:59:53 +01:00
init.sh
Revert "contrib/plugins: init with mTLS store example"
2025-07-29 03:34:49 +00:00
install-darwin.sh
change shebangs of all .sh scripts to bash
2024-06-24 14:00:43 -07:00
lang-test-infra.sh
tests/functional/lang: Change base path to the lang directory
2025-05-21 20:36:20 +02:00
lang.sh
tests/functional2/lang: migrated first tests
2025-06-01 20:19:37 +02:00
legacy-ssh-store.sh
"but doctor, I AM the untrusted store": nix doctor had wrong trustedness
2024-04-08 15:40:12 -07:00
linux-sandbox.sh
libstore/build: rewire builder's environment in presence of a global CA
2025-07-27 19:42:37 +00:00
local-store.sh
"but doctor, I AM the untrusted store": nix doctor had wrong trustedness
2024-04-08 15:40:12 -07:00
logging.sh
libstore: more precise origin info for strange structured logs
2025-02-16 14:15:36 +01:00
meson.build
tests/functional2: migrate debugger.sh
2025-10-18 11:23:43 +00:00
misc.sh
libexpr: significantly improve error messages for bad attr paths
2024-12-10 15:43:31 -08:00
multiple-outputs.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
multiple-outputs.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
nar-access.nix
libstore/binary-cache: fix catching JSON exceptions
2025-07-25 21:04:16 +02:00
nar-access.sh
libutil: reject malformed nars harder with better errors
2025-09-12 23:22:11 +02:00
nested-sandboxing.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
nix-build-examples.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
nix-build.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
nix-channel.sh
Add pre-commit checks
2024-03-29 22:57:40 -07:00
nix-collect-garbage-d.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
nix-collect-garbage-dry-run.sh
Fix dry-run flag for nix-collect-garbage
2024-07-09 13:55:05 +00:00
nix-copy-ssh-common.sh
Merge pull request #9604 from obsidiansystems/test-substitute-on-destination
2024-03-07 03:34:00 +01:00
nix-copy-ssh-ng.sh
Merge pull request #9604 from obsidiansystems/test-substitute-on-destination
2024-03-07 03:34:00 +01:00
nix-copy-ssh.sh
Merge pull request #9604 from obsidiansystems/test-substitute-on-destination
2024-03-07 03:34:00 +01:00
nix-daemon-untrusting.sh
change shebangs of all .sh scripts to bash
2024-06-24 14:00:43 -07:00
nix-profile.sh
cli: disallow ca derivations
2025-05-20 13:27:04 +02:00
optimise-store.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
output-cycles.sh
libstore: fix reporting output cycles on drvs with references to other drvs
2025-12-08 07:20:51 +01:00
output-normalization.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
parallel.builder.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
parallel.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
parallel.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
pass-as-file.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
path-from-hash-part.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
path.nix
libexpr: rectify filtering logic for filter builtins under chroot stores
2025-02-27 00:26:48 +01:00
placeholders.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
plugins.sh
tests: don't build test plugin shared libs on static builds
2024-05-12 23:04:21 +02:00
post-hook.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
pre-hook.sh
fix: pre-build-hook did not run when useChroot == false
2025-02-17 16:05:06 -08:00
push-to-store.sh
change shebangs of all .sh scripts to bash
2024-06-24 14:00:43 -07:00
read-only-store.sh
Add pre-commit checks
2024-03-29 22:57:40 -07:00
readfile-context.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
readfile-context.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
redirected-filter-source.nix
libexpr: rectify filtering logic for filter builtins under chroot stores
2025-02-27 00:26:48 +01:00
redirected-filter-source.sh
libexpr: rectify filtering logic for filter builtins under chroot stores
2025-02-27 00:26:48 +01:00
referrers.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
regression-484.sh
fix: good errors for failures caused by allowSubstitutes
2024-08-23 17:49:15 -07:00
regression-reference-checks.nix
libstore: fix "illegal reference specifier 'man'"-error in postgresql_14
2025-01-05 14:50:45 +01:00
regression-reference-checks.sh
libstore: fix "illegal reference specifier 'man'"-error in postgresql_14
2025-01-05 14:50:45 +01:00
remote-store.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
repair-chroot.sh
libstore/build: pathContentsGood is physical path aware now
2025-07-27 01:42:41 +02:00
repair.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
repl.sh
testing: unrace functional-repl
2025-09-12 23:22:11 +02:00
restricted.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
restricted.sh
libexpr: Deprecate overriding __sub and the like
2024-11-28 18:15:52 +01:00
sandboxed-certificate-authorities.sh
libstore/build: rewire builder's environment in presence of a global CA
2025-07-27 19:42:37 +00:00
secure-drv-outputs.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
secure-drv-outputs.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
selfref-gc.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
shell-hello.nix
Merge pull request #9648 from cole-h/nix-shell-ordering
2024-03-04 07:50:55 +01:00
shell.sh
Detect if in Nix3 shell
2025-03-07 07:45:08 -05:00
signing.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
simple-failing.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
simple.builder.sh
Add pre-commit checks
2024-03-29 22:57:40 -07:00
simple.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
simple.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
ssh-relay.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
store-ping.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
structured-attrs.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
structured-attrs.sh
testing: remove obsolete daemon tests
2025-07-22 10:39:32 +00:00
substitute-truncated-nar.sh
testing: drop compression from truncated nar test
2025-11-05 00:02:10 +01:00
substitute-with-invalid-ca.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
suggestions.sh
libexpr: show all missing and unexpected arguments instead of just one
2025-03-11 20:21:24 +01:00
supplementary-groups.sh
libstore: don't default build-dir to temp-dir
2025-06-24 10:49:49 +00:00
symlink-derivation.nix
Merge pull request #10456 from NixOS/fixpermdeniedbind
2024-04-11 15:43:58 +03:00
tarball.sh
tests: add fetchTarball test for symlink temporary directories
2025-10-17 18:41:58 +00:00
test-infra.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
test-libstoreconsumer.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
test-repl-characterization.sh
Implement a parser for a literate testing system for the repl
2024-03-14 14:30:38 -07:00
toString-path.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
undefined-variable.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
unsandboxed-certificate-authorities.sh
libstore/build: rewire builder's environment in presence of a global CA
2025-07-27 19:42:37 +00:00
user-envs.builder.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
user-envs.nix
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00
user-envs.sh
libstore/profiles: do not dereference current generation if it doesn't exist
2025-05-11 01:07:18 +02:00
zstd.sh
Put functional tests in tests/functional
2023-12-01 12:06:43 -05:00