Merge "fix(gc): log sudden "path in use" exceptions and recover during GC gracefully" into main

2025-01-23 06:03:33 +00:00
parent 1fe6064ced 6a41dae49a
commit cb19e24a1d
1 changed files with 10 additions and 3 deletions
@@ -746,9 +746,16 @@ void LocalStore::collectGarbage(const GCOptions & options, GCResults & results)
        for (auto & path : topoSortPaths(visited)) {
            if (!dead.insert(path).second) continue;
            if (shouldDelete) {
-                invalidatePathChecked(path);
-                deleteFromStore(path.to_string());
-                referrersCache.erase(path);
+                try {
+                    invalidatePathChecked(path);
+                    deleteFromStore(path.to_string());
+                    referrersCache.erase(path);
+                } catch (PathInUse &) {
+                    // References to upstream "bugs":
+                    // https://github.com/NixOS/nix/issues/11923
+                    // https://git.lix.systems/lix-project/lix/issues/621
+                    printInfo("Skipping deletion of path '%1%' because it is now in use, preventing its removal.", printStorePath(path));
+                }
            }
        }
    };