Merge pull request #7597 from tweag/move-implem-bit-to-implem-file

Move the `getBuildLog` implementation to its own implementation file
This commit is contained in:
Robert Hensing
2023-01-13 20:16:33 +01:00
committed by GitHub
2 changed files with 13 additions and 6 deletions
+12
View File
@@ -0,0 +1,12 @@
#include "log-store.hh"
namespace nix {
std::optional<std::string> LogStore::getBuildLog(const StorePath & path) {
auto maybePath = getBuildDerivationPath(path);
if (!maybePath)
return std::nullopt;
return getBuildLogExact(maybePath.value());
}
}
+1 -6
View File
@@ -11,12 +11,7 @@ struct LogStore : public virtual Store
/* Return the build log of the specified store path, if available,
or null otherwise. */
std::optional<std::string> getBuildLog(const StorePath & path) {
auto maybePath = getBuildDerivationPath(path);
if (!maybePath)
return std::nullopt;
return getBuildLogExact(maybePath.value());
}
std::optional<std::string> getBuildLog(const StorePath & path);
virtual std::optional<std::string> getBuildLogExact(const StorePath & path) = 0;