guiwf/lix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,044 Commits 37 Branches 40 Tags
8f44edc83ea072bd9559f40fb6e308ee501afbf0
Commit Graph
14044 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
John EricsonmupdtRobert Hensing
 		8f44edc83e Tidy up and comment daemon CLI 
Some of the factoring out was taken from #7912 by @mupdt. Thanks!

No behavior should be changed in this commit.

Co-Authored-By: mupdt <25388474+mupdt@users.noreply.github.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
 2023-04-07 16:49:52 -04:00
Robert HensingandGitHub 4411c7d7e0 Merge pull request #8179 from tweag/disable-gc-on-coroutine 
disable gc on coroutine
 2023-04-07 18:21:11 +02:00
John EricsonandGitHub 0746951be1 Finish converting existing comments for internal API docs (#8146) 
* Finish converting existing comments for internal API docs

99% of this was just reformatting existing comments. Only two exceptions:

- Expanded upon `BuildResult::status` compat note

- Split up file-level `symbol-table.hh` doc comments to get
  per-definition docs

Also fixed a few whitespace goofs, turning leading tabs to spaces and
removing trailing spaces.

Picking up from #8133

* Fix two things from comments

* Use triple-backtick not indent for `dumpPath`

* Convert GNU-style `\`..'` quotes to markdown style in API docs

This will render correctly.
 2023-04-07 13:55:28 +00:00
Robert HensingandGitHub 54b3b6ebc6 Merge pull request #7887 from obsidiansystems/add-derivation 
`nix derivation add`, `show-derivation` -> `derivation show`
 2023-04-07 15:02:35 +02:00
Yorick van PeltandThéophane Hufschmitt 62ddd8633c Add talkative msg for coro gc debug 2023-04-07 14:54:50 +02:00
Yorick van PeltandThéophane Hufschmitt 58d24a4cb6 Always disable GC in a coroutine unless the patch is applied 2023-04-07 14:54:38 +02:00
Yorick van PeltandThéophane Hufschmitt 00bc34430b DisableGC: replace by CoroutineContext, std::shared_ptr<void> 2023-04-07 14:53:40 +02:00
Yorick van PeltandThéophane Hufschmitt 2c53ef1bfe Disable GC inside coroutines on mac OS 2023-04-07 14:52:59 +02:00
John Ericson 9d1105824f Add release notes for nix derivation {add,show} 2023-04-07 08:35:59 -04:00
John Ericson 59e0728714 Create nix derivation add command 
Also refine `nix derivation show`'s docs very slightly.
 2023-04-07 08:34:58 -04:00
John Ericson 27597f8131 Rename files to reflect new nix derivation show name 
This will match the files we added for `nix add derivation` in the rest
of this PR.
 2023-04-07 08:34:58 -04:00
John Ericson 2b98af2e62 nix show-derivation -> nix derivation show 2023-04-07 08:34:58 -04:00
John Ericson 4e9f32f993 Liberate checkDerivationOutputs from LocalStore 
Make it instead a method on `Derivation` that can work with any store.
We will need this for a CLI command to create a derivation.
 2023-04-07 08:34:58 -04:00
John Ericson b200784cec Include the name in the JSON for derivations 
This is non-breaking change in the to-JSON direction. This *is* a
breaking change in the from-JSON direction, but we don't care, as that
is brand new in this PR.

`nix show-derivation --help` currently has the sole public documentation
of this format, it is updated accordingly.
 2023-04-07 08:34:58 -04:00
John Ericson fe9cbe838c Create Derivation::fromJSON 
And test, of course
 2023-04-07 08:34:58 -04:00
Théophane HufschmittandGitHub 81dfc2b012 Merge pull request #7515 from MatthewCroughan/mc/check-trusted-user 
Add Store::isTrustedClient()
 2023-04-07 13:41:32 +02:00
matthewcroughanandJohn Ericson 9207f94582 Add Store::isTrustedClient() 
This function returns true or false depending on whether the Nix client
is trusted or not. Mostly relevant when speaking to a remote store with
a daemon.

We include this information in `nix ping store` and `nix doctor`

Co-Authored-By: John Ericson <John.Ericson@Obsidian.Systems>
 2023-04-06 19:59:57 -04:00
Théophane HufschmittGitHubValentin GagarinEelco DolstraJohn Ericson
 		9185639631 Document the concept of “experimental feature” (#5930) 
Add a page explaining what “experimental features” are, when and how they should be used

Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
 2023-04-06 11:25:22 +00:00
Valentin GagarinandGitHub bbdb5a58c7 Merge pull request #7849 from milahu/fix-man-nix-shell 
docs: fix nix-shell commands
 2023-04-05 13:06:59 +02:00
milahuandValentin Gagarin 1ac10808ba docs: fix nix-shell commands 2023-04-05 12:38:36 +02:00
Valentin GagarinandGitHub 3586e97e23 Merge pull request #8167 from fricklerhandwerk/doc-nix-database 
glossary: Nix database
 2023-04-05 11:17:35 +02:00
Mike (stew) O'ConnorandValentin Gagarin cab5266092 add a definition of the nix database to the glossary 
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
 2023-04-05 10:50:34 +02:00
Valentin Gagarin ed5d0c1362 add anchor to 'local store' 2023-04-05 10:48:59 +02:00
Théophane HufschmittandGitHub 1707e7ea5f Merge pull request #7579 from fricklerhandwerk/review-process 
review process: all PRs must be triaged
 2023-04-05 01:57:17 +02:00
Valentin Gagarin f912ab89cc only triage non-trivial pull requests 
the team perceives triaging literally everything as too much overhead,
and there is a desire to allow for more parallel action.
 2023-04-05 01:27:15 +02:00
Théophane HufschmittandGitHub d93c1514eb Merge pull request #7944 from yorickvP/fix-curRepl 
NixRepl::mainLoop: restore old curRepl on function exit
 2023-04-04 09:44:47 +02:00
Théophane HufschmittandGitHub 523c3f7225 Merge pull request #8157 from hercules-ci/switch-bugs 
Fix current and future `switch` bugs
 2023-04-03 20:43:02 +02:00
Eelco DolstraandGitHub 81491e1379 Merge pull request #8042 from lheckemann/alt-lockfiles 
Allow specifying alternative paths for reading/writing flake locks
 2023-04-03 19:28:09 +02:00
Robert Hensing bf2c5c3958 nix-store.cc: Refactor, remove qDefault 2023-04-03 18:45:20 +02:00
Robert Hensing fba7be80eb Enable -Werror=switch-enum 
switch statements must now match all enum values or disable the
warning.

Explicit is good. This has helped us find two bugs, after solving
another one by debugging.

From now on, adding to an enum will raise errors where they are
not explicitly handled, which is good for productivity, and helps
us decide the correct behavior in all usages.

Notably still excluded from this though are the cases where the
warning is disabled by local pragmas.

fromTOML.cc did not build despite a top-level pragma, so I've had
to resort to a makefile solution for that.
 2023-04-03 18:45:20 +02:00
Robert Hensing 9470ee877d Allow open switch-enum in 5 places 2023-04-03 18:45:20 +02:00
John EricsonandGitHub acc3314376 Merge pull request #7611 from obsidiansystems/structured-command-stabilization 
Stuctured command stability
 2023-04-03 12:22:10 -04:00
Robert Hensing 3dac4c7874 Add explicit case statements where -Wswitch-enum would report them 2023-04-03 18:17:32 +02:00
Robert Hensing ed7885017c Fix systemd logging for lvlNotice: eqv to lvlInfo, not lvlVomit 2023-04-03 18:17:32 +02:00
Robert Hensing 62cacc371f Fix BuildResult.toString() for NoSubstituters 2023-04-03 18:17:30 +02:00
John Ericson 4a0b893d5e Stuctured command stability 
Prior to this, there was an ad-hoc whitelist in `main.cc`. Now, every
command states its stability.

In a future PR, we will adjust the manual to take advantage of this new
information in the JSON.
(It will be easier to do that once we have some experimental feature
docs to link too; see #5930 and #7798.)
 2023-04-03 11:48:21 -04:00
Robert HensingandGitHub f3a6de6ba9 Merge pull request #8148 from hercules-ci/fix-issue-8119-printValue-tBlackhole-abort 
eval: Fix crash on missing printValue tBlackhole case
 2023-04-03 16:05:55 +02:00
Eelco DolstraandGitHub ac4318a1b9 Merge pull request #8152 from obsidiansystems/move-querySubstitutablePathInfos 
Move `querySubstitutablePathInfos` from `LocalStore` to `Store`
 2023-04-03 15:36:33 +02:00
Robert Hensing 1c55544a42 eval: Fix crash on missing printValue tBlackhole case 
Fixes #8119
 2023-04-03 15:32:42 +02:00
Théophane HufschmittandGitHub 70bb7b7289 Merge pull request #7610 from obsidiansystems/gate-default-settings 
Punt on improper global flags for now
 2023-04-03 14:02:45 +02:00
Théophane HufschmittandGitHub a06ea8db77 Merge pull request #8039 from obsidiansystems/prioritize-testing 
Prioritize testing in the maintainers process docs
 2023-04-03 13:46:31 +02:00
Eelco DolstraandGitHub 5256ba6d87 Merge pull request #8151 from obsidiansystems/internal-api-docs-pr-template 
Mention internal API docs in PR template
 2023-04-03 10:49:48 +02:00
John Ericson 9383520b75 Move querySubstitutablePathInfos from LocalStore to Store 
The code is not local-store-specific, so we should share it with all
stores. More uniform behavior is better, and a less store-specific
functionality is more maintainable.

This fixes a FIXME added in f73d911628 by @edolstra himself.
 2023-04-02 20:32:01 -04:00
John Ericson ca3937fb82 Mention internal API docs in PR template 
I think we want to ensure that all new items in headers are documented,
and the documentation on modified items is kept up to date.

It will take a while to document the backlog of undocumented things, but
we can at least ensure that new items don't extend that backlog.
 2023-04-02 19:44:44 -04:00
John EricsonandGitHub 2ef99cd104 Merge pull request #8122 from bjornfor/use-nix-store-l-unless-experimental-enabled 
Don't recommend 'nix log' unless experimental feature is enabled
 2023-04-01 14:50:16 -04:00
John EricsonandGitHub ea1cbc3df5 Merge pull request #8133 from obsidiansystems/improve-internal-api-docs 
Extend internal API docs, part 2
 2023-04-01 12:42:03 -04:00
John Ericson f4ab297b31 Ensure all headers have #pragma once and are in API docs 
`///@file` makes them show up in the internal API dos. A tiny few were
missing `#pragma once`.
 2023-03-31 23:19:44 -04:00
John EricsonandEelco Dolstra abd5e7dec0 Extend internal API docs, part 2 
Picking up from #8111.

Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
 2023-03-31 23:01:40 -04:00
John EricsonandGitHub 8ae9d66940 Merge pull request #8142 from patricksjackson/atomic-sync 
Replace unnecessary Sync<uint64_t> with std::atomic<uint64_t>
 2023-03-31 21:49:20 -04:00
Patrick Jackson 2b905d1d35 Replace unnecessary Sync<uint64_t> with std::atomic<uint64_t> 2023-03-31 17:56:25 -07:00