Jade LovelaceandRebecca Turner
0cc285f87b
Fixes:
- Identifiers starting with _ are prohibited
- Some driveby header dependency cleaning which wound up with doing some
extra fixups.
- Fucking C style casts, man. C++ made these 1000% worse by letting you
also do memory corruption with them with references.
- Remove casts to Expr * where ExprBlackHole is an incomplete type by
introducing an explicitly-cast eBlackHoleAddr as Expr *.
- An incredibly illegal cast of the text bytes of the StorePath hash
into a size_t directly. You can't DO THAT.
Replaced with actually parsing the hash so we get 100% of the bits
being entropy, then memcpying the start of the hash. If this shows
up in a profile we should just make the hash parser faster with a
lookup table or something sensible like that.
- This horrendous bit of UB which I thankfully slapped a deprecation
warning on, built, and it didn't trigger anywhere so it was dead
code and I just deleted it. But holy crap you *cannot* do that.
inline void mkString(const Symbol & s)
{
mkString(((const std::string &) s).c_str());
}
- Some wrong lints. Lots of wrong macro lints, one wrong
suspicious-sizeof lint triggered by the template being instantiated
with only pointers, but the calculation being correct for both
pointers and not-pointers.
- Exceptions in destructors strike again. I tried to catch the
exceptions that might actually happen rather than all the exceptions
imaginable. We can let the runtime hard-kill it on other exceptions
imo.
Change-Id: I71761620846cba64d66ee7ca231b20c061e69710
48 lines
1.6 KiB
C++
48 lines
1.6 KiB
C++
#pragma once
|
|
///@file
|
|
|
|
#include <cassert>
|
|
#include <exception>
|
|
|
|
/**
|
|
* A trivial class to run a function at the end of a scope.
|
|
*/
|
|
template<typename Fn>
|
|
class Finally
|
|
{
|
|
private:
|
|
Fn fun;
|
|
bool movedFrom = false;
|
|
|
|
public:
|
|
Finally(Fn fun) : fun(std::move(fun)) { }
|
|
// Copying Finallys is definitely not a good idea and will cause them to be
|
|
// called twice.
|
|
Finally(Finally &other) = delete;
|
|
Finally(Finally &&other) : fun(std::move(other.fun)) {
|
|
other.movedFrom = true;
|
|
}
|
|
// NOLINTNEXTLINE(bugprone-exception-escape): the noexcept is declared properly here, the analysis seems broken
|
|
~Finally() noexcept(noexcept(fun()))
|
|
{
|
|
try {
|
|
if (!movedFrom)
|
|
fun();
|
|
} catch (...) {
|
|
// finally may only throw an exception if exception handling is not already
|
|
// in progress. if handling *is* in progress we have to return cleanly here
|
|
// but are still prohibited from doing so since eating the exception would,
|
|
// in almost all cases, mess up error handling even more. the only good way
|
|
// to handle this is to abort entirely and leave a message, so we'll assert
|
|
// (and rethrow anyway, just as a defense against possible NASSERT builds.)
|
|
if (std::uncaught_exceptions()) {
|
|
assert(false &&
|
|
"Finally function threw an exception during exception handling. "
|
|
"this is not what you want, please use some other methods (like "
|
|
"std::promise or async) instead.");
|
|
}
|
|
throw;
|
|
}
|
|
}
|
|
};
|